1335843 - Secure HTML bugmail body begins with HUGE "Subject: [Bug NNN] Bug-summary", which usually causes overflow in my email client

Status: VERIFIED FIXED

(bugzilla.mozilla.org :: Email Notifications, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: redacted screenshot of secure bugmail with huge "Subject" text at the beginning

STR:
 1. View some decrypted secure bugmail in Thunderbird (using e.g. Enigmail)

ACTUAL RESULTS:
See attached (redacted) screenshot - a huge fraction of the visible space in the bugmail is occupied by the bug summary in a huge font-size.


This makes security bugmail much harder to skim through [unless my email client is fullscreen], because the useful content (the information that changed) is often pushed down & out of view.

Comment 1

[Daniel Holbert [:dholbert]]

EXPECTED RESULTS:
The "Subject: [Bug NNN] Bug-summary" text should be much smaller in this secure HTML bugmail -- ideally, just the same size as the rest of the text in the email (though maybe bold if you want it to stand out). There's no reason to make it so huge.

Comment 2

[Daniel Holbert [:dholbert]]

(If someone tweaks some bug-flags and adds a comment on a secure bug at the same time, it's pretty much guaranteed that I won't be able to see their comment in my 3-pane Thunderbird UI, because it will be pushed "below the fold" by this huge subject line. If the subject line were a more reasonable size, then this wouldn't be an issue.)

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: redacted screenshot #2 (with a slightly longer bug summary)

Here's a screenshot from another bug with a longer bug summary. As you can see, the bug title hogs basically all of the space here, and pushes all of the useful bugmail information out of view.

Comment 4

[David Lawrence [:dkl]]

This is due to the subject being injected into the HTML body before encryption so that the end user can see what the subject should have been. The actual email subject is always scrubbed of the real summary. Also we are adding <h1> around the subject which makes it large in Thunderbird. Not sure why we need <h1> and we can look into just making it normal text.

dkl

Comment 5

[David Lawrence [:dkl]]

Attachment: 1335843_1.patch

Comment 6

[Daniel Holbert [:dholbert]]

Yeah, the <h1> is the problem here. Thanks!

Comment 7

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8833320 [details] [diff] [review]
1335843_1.patch

Review of attachment 8833320 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

Comment 8

[David Lawrence [:dkl]]

To https://github.com/mozilla-bteam/bmo.git
   bc705ae..a7317dc  master -> master

Comment 9

[David Lawrence [:dkl]]

This is now live.

dkl

Comment 10

[Daniel Holbert [:dholbert]]

Verified fixed (the text is no longer huge, in the secure bugmail that I've received this morning).

Thanks!