Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Fix shape of gcli-tooltip (callout is rectangular)

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Developer Tools: Graphic Commandline and Toolbar
P2
normal
RESOLVED FIXED
6 months ago
2 months ago

People

(Reporter: magicp, Assigned: miker)

Tracking

Trunk
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox51 wontfix, firefox52 wontfix, firefox53 wontfix, firefox54 wontfix, firefox55 fixed)

Details

(Whiteboard: [todo-mr])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

6 months ago
Created attachment 8832602 [details]
fix-shape-of-gcli-tooltip.png

[Steps to reproduce]
1. Start Nightly
2. Open GCLI (Shift+F2)
3. Type "he" or "hel", and hit enter
4. Confirm shape of gcli-tooltip / gcli-tooltip-connector

[Actual Results]
- Shape of gcli-tooltip-connector is square. (Is this intentional?)
- In case of typing "he", gcli-tooltip window has not enough width

[Expected Results]
- Shape of gcli-tooltip-connector is arrow.
- gcli-tooltip window has enough width.
(Reporter)

Updated

6 months ago
status-firefox51: --- → affected
status-firefox52: --- → affected
status-firefox53: --- → affected
OS: Unspecified → All
Hardware: Unspecified → All

Updated

5 months ago
Component: Developer Tools: Console → Developer Tools: Graphic Commandline and Toolbar
Mass wontfix for bugs affecting firefox 52.
status-firefox52: affected → wontfix
Simple change the callout CSS (#gcli-tooltip-connector) to make it triangular.
Assignee: nobody → mratcliffe
Priority: -- → P2
Summary: Fix shape of gcli-tooltip → Fix shape of gcli-tooltip (callout is rectangular)
Whiteboard: [todo-mr]
Created attachment 8864497 [details]
Fixed

Callout changed to triangle.
Comment hidden (mozreview-request)

Comment 5

3 months ago
mozreview-review
Comment on attachment 8864501 [details]
Bug 1335869 - Add triangular callout to GCLI tooltip

https://reviewboard.mozilla.org/r/136186/#review139572

Much better than before :) r+
Attachment #8864501 - Flags: review?(nchevobbe) → review+

Comment 6

3 months ago
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/81938edded9d
Add triangular callout to GCLI tooltip r=nchevobbe

Comment 7

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/81938edded9d
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I have to reproduced this bug with Nightly 53.0a1 (2017-02-01) (64-bit) on Windows 7 64 bit;

The Bug's fix is verified on Latest Nightly 55.0a1

Build ID 	20170513030205
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[Testday-20170512]
status-firefox51: affected → wontfix
status-firefox53: affected → wontfix
status-firefox54: affected → wontfix
You need to log in before you can comment on or make changes to this bug.