1335869 - Fix shape of gcli-tooltip (callout is rectangular)

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P2)

Description

[magicp]

Attachment: fix-shape-of-gcli-tooltip.png

[Steps to reproduce]
1. Start Nightly
2. Open GCLI (Shift+F2)
3. Type "he" or "hel", and hit enter
4. Confirm shape of gcli-tooltip / gcli-tooltip-connector

[Actual Results]
- Shape of gcli-tooltip-connector is square. (Is this intentional?)
- In case of typing "he", gcli-tooltip window has not enough width

[Expected Results]
- Shape of gcli-tooltip-connector is arrow.
- gcli-tooltip window has enough width.

Comment 1

[Julien Cristau [:jcristau]]

Mass wontfix for bugs affecting firefox 52.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Simple change the callout CSS (#gcli-tooltip-connector) to make it triangular.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Fixed

Callout changed to triangle.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1335869 - Add triangular callout to GCLI tooltip

Changes:

- Callout now changed to a triangle.
- Finally found a way to make the GCLI window 80% of viewport width (80vw).
- overflow-x is now hidden as the output width should be plenty wide enough to display any text.

The implementation is much prettier and works far better than it previously did. It is still not perfect e.g. when the output is scrollable we lose the triangular callout. I believe this was intentional in an effort to fit as much text in the output box as possible.

Review commit: https://reviewboard.mozilla.org/r/136186/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136186/

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8864501 [details]
Bug 1335869 - Add triangular callout to GCLI tooltip

https://reviewboard.mozilla.org/r/136186/#review139572

Much better than before :) r+

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81938edded9d
Add triangular callout to GCLI tooltip r=nchevobbe

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/81938edded9d

Comment 8

[Md.Tarikul Islam Oashi]

I have to reproduced this bug with Nightly 53.0a1 (2017-02-01) (64-bit) on Windows 7 64 bit;

The Bug's fix is verified on Latest Nightly 55.0a1

Build ID 	20170513030205
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[Testday-20170512]