Closed Bug 1335869 Opened 3 years ago Closed 3 years ago

Fix shape of gcli-tooltip (callout is rectangular)

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P2)

defect

Tracking

(firefox51 wontfix, firefox52 wontfix, firefox53 wontfix, firefox54 wontfix, firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox51 --- wontfix
firefox52 --- wontfix
firefox53 --- wontfix
firefox54 --- wontfix
firefox55 --- fixed

People

(Reporter: magicp.jp, Assigned: miker)

Details

(Whiteboard: [todo-mr])

Attachments

(3 files)

[Steps to reproduce]
1. Start Nightly
2. Open GCLI (Shift+F2)
3. Type "he" or "hel", and hit enter
4. Confirm shape of gcli-tooltip / gcli-tooltip-connector

[Actual Results]
- Shape of gcli-tooltip-connector is square. (Is this intentional?)
- In case of typing "he", gcli-tooltip window has not enough width

[Expected Results]
- Shape of gcli-tooltip-connector is arrow.
- gcli-tooltip window has enough width.
OS: Unspecified → All
Hardware: Unspecified → All
Component: Developer Tools: Console → Developer Tools: Graphic Commandline and Toolbar
Mass wontfix for bugs affecting firefox 52.
Simple change the callout CSS (#gcli-tooltip-connector) to make it triangular.
Assignee: nobody → mratcliffe
Priority: -- → P2
Summary: Fix shape of gcli-tooltip → Fix shape of gcli-tooltip (callout is rectangular)
Whiteboard: [todo-mr]
Attached image Fixed
Callout changed to triangle.
Comment on attachment 8864501 [details]
Bug 1335869 - Add triangular callout to GCLI tooltip

https://reviewboard.mozilla.org/r/136186/#review139572

Much better than before :) r+
Attachment #8864501 - Flags: review?(nchevobbe) → review+
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/81938edded9d
Add triangular callout to GCLI tooltip r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/81938edded9d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I have to reproduced this bug with Nightly 53.0a1 (2017-02-01) (64-bit) on Windows 7 64 bit;

The Bug's fix is verified on Latest Nightly 55.0a1

Build ID 	20170513030205
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[Testday-20170512]
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.