1335885 - mochitest layout/forms/test/test_bug1301290.html is failing when run on ubuntu 16.04 vs 12.04

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

we are working on running all of our tests on ubuntu 16.04 vs 12.04, and there are some new failures to look at:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ac0bd83bb7cd8ba2ecad1571c4d2038d8a70ba4&filter-searchStr=mochitest-e10s-8&selectedJob=73652332


here is the list of failures:
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug1301290.html | width did not increase
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug1301290.html | height did not increase
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | An inner div should be the target of the event - got "INPUT", expected "DIV"
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | the target div should be the editor div
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | An inner div should be the target of the event - got "INPUT", expected "DIV"
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | the target div should be the editor div
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | An inner div should be the target of the event - got "INPUT", expected "DIV"
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | the target div should be the editor div
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | An inner div should be the target of the event - got "INPUT", expected "DIV"
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | the target div should be the editor div
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | An inner div should be the target of the event - got "INPUT", expected "DIV"
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | the target div should be the editor div
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | An inner div should be the target of the event - got "INPUT", expected "DIV"
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | the target div should be the editor div
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | An inner div should be the target of the event - got "INPUT", expected "DIV"
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | the target div should be the editor div
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | An inner div should be the target of the event - got "INPUT", expected "DIV"
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | the target div should be the editor div
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | An inner div should be the target of the event - got "INPUT", expected "DIV"
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | the target div should be the editor div
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | An inner div should be the target of the event - got "INPUT", expected "DIV"
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | the target div should be the editor div
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | An inner div should be the target of the event - got "INPUT", expected "DIV"
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | the target div should be the editor div
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | An inner div should be the target of the event - got "INPUT", expected "DIV"
TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug549170.html | the target div should be the editor div

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

I am not sure who could help debug these issues- I am happy to help run things on try server or get access to a "one click loaner".

:jet, who could help out with these tests something this month?

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

on mochitest-3, I see this failure:
dom/events/test/test_bug946632.html | <input> horizontal line scroll targets <input> - got [object HTMLDivElement], expected [object HTMLInputElement]

it is another case of getting a div instead of an input, same with bug 1335888 which I filed for a similar layout issue.

so I suspect this is all the same root cause

Comment 3

[Jet Villegas (inactive)]

dholbert will have a look here...

Comment 4

[Daniel Holbert [:dholbert]]

I just spot-checked & can reproduce the "test_bug1301290.html | width did not increase" (and height) mochitest failure locally, BTW. So hopefully this shouldn't be too hard to sort out...

Comment 5

[Daniel Holbert [:dholbert]]

I'm spinning off the test_bug549170.html failures into a separate bug (bug 1337466).  This bug here will just focus on the test_bug1301290.html failures (the first ones noted in comment 0).

Comment 6

[Daniel Holbert [:dholbert]]

So this change was caused by bug 1337474, combined with the fact that scrollbars are skinnier on Ubuntu 16.10 as compared to 12.04, which gives us a smaller resizer-thumb on the unthemed textarea here.

We may want to fix bug 1337474, but for now, as a sort of band-aid, we can simply adjust the test's synthesized click to be a little closer to the corner.

That gets this test to be passing again, and the test still is effective at testing the problem that it originally was meant to test -- i.e. it still legitimately fails if I backout the patch that it landed with.

I'll post a patch later today to do this.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

sounds good- if we should consider another theme for ubuntu 16, that is a possibility.

Comment 8

[Daniel Holbert [:dholbert]]

You mean, change the Ubuntu/GTK theme on the test boxes? Nah, we should probably stick with the defaults, to better match our users' most-likely configurations.  (Interesting/sneaky thought, though! :))

Comment 9

[Daniel Holbert [:dholbert]]

Attachment: Bug 1335885: Adjust click position in test_bug1301290.html to more reliably target resizer.

The resizer in question is smaller in Ubuntu 16.04 than on other platforms (due
to smaller scrollbars in the default OS theme), so we need to target our click
closer to the corner of the element in order to hit the resizer.

Review commit: https://reviewboard.mozilla.org/r/110752/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110752/

Comment 10

[Mats Palmgren (inactive)]

Comment on attachment 8835062 [details]
Bug 1335885: Adjust click position in test_bug1301290.html to more reliably target resizer.

https://reviewboard.mozilla.org/r/110752/#review112170

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b77a472a5ce6
Adjust click position in test_bug1301290.html to more reliably target resizer. r=mats

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b77a472a5ce6