Closed Bug 13359 Opened 21 years ago Closed 20 years ago

Assertions in menu code on startup

Categories

(Core :: XUL, defect, P1)

All
Mac System 8.5
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: sfraser_bugs, Assigned: mikepinkerton)

Details

On starting up with a browser window, I see assertions in
nsMenu::NSStringSetMenuItemText(), SetMenuItemFontID failed. This seems to be
because we're adding empty menu items somehow.
Status: NEW → ASSIGNED
Target Milestone: M11
Well then don't add empty items. I filed a bug on that last week sometime.

I like this assertion... it points out that something bad is happening. Would
people prefer a silent failure on my end?
The assertion does not happen as a result of test directly for an empty item, but
happen because of an error returned by a Toolbox call. If you want to assert
about empty items, this should happen XP, and be somewhere else.
Ok, I guess my question is this: what would you like me do in the case of empty
items? Fail silently and not insert them?
It's probably better to put in "(no title)" or something like that, and assert.
Priority: P3 → P1
mass-moving most m11 bugs to m12
Target Milestone: M12 → M16
I havn't seen this in quite some time, if it returns I'm sure I'll notice.
pushing out.
dividing up phillips bugs, he no longer works here
Assignee: saari → pinkerton
Status: ASSIGNED → NEW
Taking menu/popup bugs.
reopen if this hasn't been seen.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
i don't see this occurring...
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.