1335943 - Completions are not setting the right Origin Attribute

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P2)

Description

[François Marier [:francois]]

It looks like the hash completer:

http://searchfox.org/mozilla-central/rev/e95e4ed8b5229a29dacc32c0b90968df5e7a6ff3/toolkit/components/url-classifier/nsUrlClassifierHashCompleter.js#392-432

doesn't set the NECKO_SAFEBROWSING_FIRST_PARTY_DOMAIN origin attribute and so it will not use the same cookie jar as Safe Browsing updates.

Note that this is not a regression caused by bug 1320402, instead, it should have been done as part of bug 897516 but was forgotten.

Comment 1

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: Bug 1335943 - Use the right origin attribute in Safe Browsing completions.

Review commit: https://reviewboard.mozilla.org/r/151274/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151274/

Comment 2

[François Marier [:francois]]

Comment on attachment 8879872 [details]
Bug 1335943 - Use the right origin attribute in Safe Browsing completions.

https://reviewboard.mozilla.org/r/151274/#review156380

::: commit-message-95543:1
(Diff revision 1)
> +Bug 1335943 - Completions are not setting the right Origin Attribute. r?francois

I would suggest phrasing this as a fix instead of a bug:

"Use the right origin attribute in Safe Browsing completions."

::: netwerk/test/unit/test_cookiejars_safebrowsing.js:198
(Diff revision 1)
>    }
>  
>    function completeCheckSafeBrowsingCookie(request, data, context) {
>      // Confirm that all >> THREE << cookies are sent back over the channel:
>      //   a) the safebrowsing cookie set when updating
> -    //   b) the regular cookie with custom loadcontext defined in this test.
> +    //   b) the safebrowsing cookie set when send gethash

"when sending gethash"

Comment 3

[Dimi Lee [ooo 16.04 - 21.04］]

Comment on attachment 8879872 [details]
Bug 1335943 - Use the right origin attribute in Safe Browsing completions.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151274/diff/1-2/

Comment 4

[Dimi Lee [ooo 16.04 - 21.04］]

Comment on attachment 8879872 [details]
Bug 1335943 - Use the right origin attribute in Safe Browsing completions.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151274/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e13653ff2d5c
Use the right origin attribute in Safe Browsing completions. r=francois

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e13653ff2d5c