URLCLASSIFIER_UPDATE_ERROR shows a number of unexpected values coming from the server

RESOLVED FIXED in Firefox 54

Status

()

Toolkit
Safe Browsing
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: francois, Assigned: dimi)

Tracking

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

(Whiteboard: #sbv4-m5)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
https://telemetry.mozilla.org/new-pipeline/dist.html#!cumulative=0&end_date=2017-01-30&keys=google!google4!mozilla!other&max_channel_version=nightly%252F54&measure=URLCLASSIFIER_UPDATE_ERROR&min_channel_version=null&product=Firefox&sanitize=1&sort_keys=submissions&start_date=2017-01-23&table=1&trim=1&use_submission_date=0 shows that we are getting a lot of these errors:

- 1 = unspecified error
- 2 = addition of an already existing prefix

and a very small number of these:

- 4 = removal index out of bounds
- 5 = checksum mismatch

We should investigate to see if we can get more details on the "unspecified error" case and whether we can get a sample of #2 that we could send to Google.
(Assignee)

Updated

a year ago
Assignee: nobody → dlee
Status: NEW → ASSIGNED
(Assignee)

Comment 1

a year ago
Just a quick update about possible error:

1. Out of memory when generate prefix set
2. file operation error while manipulate database.
3. update when shutdown(Shutdown-Aware code).
4. Invalid update(there is no valid table)
5. No lookup cache for that table
6. Protocol Parser return an error
(Reporter)

Updated

a year ago
Blocks: 1312939
No longer blocks: 1167038
(Assignee)

Updated

a year ago
Whiteboard: #sbv4-m5
Comment hidden (mozreview-request)
(Reporter)

Comment 3

a year ago
mozreview-review
Comment on attachment 8839824 [details]
Bug 1335974 - Add more error codes to URLCLASSIFIER_UPDATE_ERROR.

https://reviewboard.mozilla.org/r/114402/#review116548
Attachment #8839824 - Flags: review?(francois) → review+
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 4

a year ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/428e3fea1a3e
Add more error codes to URLCLASSIFIER_UPDATE_ERROR. r=francois
Keywords: checkin-needed

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/428e3fea1a3e
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.