Don't use virtual method for non override methods in EditorBase and TextEditor

RESOLVED FIXED in Firefox 54

Status

()

Core
Editor
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

a year ago
Although some methods don't override by another class, we use virtual keyword.  So we shouldn't use virtual method for EditorBase and TextEditor if possible.
(Assignee)

Updated

a year ago
Assignee: nobody → m_kato
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

a year ago
mozreview-review
Comment on attachment 8832768 [details]
Bug 1335997 - Part 1. Don't use virtual method for GetAndInitDocEncoder and InsertTextFromTransferable.

https://reviewboard.mozilla.org/r/109006/#review110188
Attachment #8832768 - Flags: review?(masayuki) → review+

Comment 4

a year ago
mozreview-review
Comment on attachment 8832769 [details]
Bug 1335997 - Part 2. Don't use virtual method for NotifyDocumentListeners and ScrollSelectionIntoView.

https://reviewboard.mozilla.org/r/109008/#review110190
Attachment #8832769 - Flags: review?(masayuki) → review+

Comment 5

a year ago
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/abb609307363
Part 1. Don't use virtual method for GetAndInitDocEncoder and InsertTextFromTransferable. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/d6fd02e91afb
Part 2. Don't use virtual method for NotifyDocumentListeners and ScrollSelectionIntoView. r=masayuki

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/abb609307363
https://hg.mozilla.org/mozilla-central/rev/d6fd02e91afb
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.