Closed Bug 1336020 Opened 3 years ago Closed 3 years ago

postMessages should have transferable as [] by default

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(2 files, 2 obsolete files)

This change should not impact web content.
Assignee: nobody → amarchesini
Attachment #8832802 - Flags: review?(bugs)
Attachment #8832802 - Attachment description: transfer.patch → part 1 - default value for transferable sequence in postMessages
Attachment #8832817 - Flags: review?(bugs)
Comment on attachment 8832802 [details] [diff] [review]
part 1 - default value for transferable sequence in postMessages

So it doesn't matter that earlier we passed empty array to structured clone writing and now we pass undefined?
Attachment #8832802 - Flags: review?(bugs) → review+
Comment on attachment 8832817 [details] [diff] [review]
part 2 - transferables should be 'object' in WebIDL

So, this makes us always create array object. Even if there isn't any need.
I'm pretty sure that would show up in microbenchmarks.
Attachment #8832817 - Flags: review?(bugs) → review-
Attachment #8832817 - Attachment is obsolete: true
Attachment #8832867 - Flags: review?(bugs)
Attachment #8832867 - Attachment is obsolete: true
Attachment #8832867 - Flags: review?(bugs)
Attachment #8832879 - Flags: review?(bugs)
Attachment #8832879 - Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c7431468e5d
postMessages should have transferable as [] by default, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3d718ec7f07
transferables should be arrays of objects, r=smaug
https://hg.mozilla.org/mozilla-central/rev/4c7431468e5d
https://hg.mozilla.org/mozilla-central/rev/c3d718ec7f07
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.