postMessages should have transferable as [] by default

RESOLVED FIXED in Firefox 54

Status

()

Core
DOM
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: baku, Assigned: baku)

Tracking

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

a year ago
This change should not impact web content.
(Assignee)

Comment 1

a year ago
Created attachment 8832802 [details] [diff] [review]
part 1 - default value for transferable sequence in postMessages
Assignee: nobody → amarchesini
Attachment #8832802 - Flags: review?(bugs)
(Assignee)

Updated

a year ago
Attachment #8832802 - Attachment description: transfer.patch → part 1 - default value for transferable sequence in postMessages
(Assignee)

Comment 2

a year ago
Created attachment 8832817 [details] [diff] [review]
part 2 - transferables should be 'object' in WebIDL
Attachment #8832817 - Flags: review?(bugs)
Comment on attachment 8832802 [details] [diff] [review]
part 1 - default value for transferable sequence in postMessages

So it doesn't matter that earlier we passed empty array to structured clone writing and now we pass undefined?
Attachment #8832802 - Flags: review?(bugs) → review+
Comment on attachment 8832817 [details] [diff] [review]
part 2 - transferables should be 'object' in WebIDL

So, this makes us always create array object. Even if there isn't any need.
I'm pretty sure that would show up in microbenchmarks.
Attachment #8832817 - Flags: review?(bugs) → review-
(Assignee)

Comment 5

a year ago
Created attachment 8832867 [details] [diff] [review]
part 2 - transferables should be 'object' in WebIDL
Attachment #8832817 - Attachment is obsolete: true
Attachment #8832867 - Flags: review?(bugs)
(Assignee)

Comment 6

a year ago
Created attachment 8832879 [details] [diff] [review]
part 2 - transferables should be 'object' in WebIDL
Attachment #8832867 - Attachment is obsolete: true
Attachment #8832867 - Flags: review?(bugs)
Attachment #8832879 - Flags: review?(bugs)

Updated

a year ago
Attachment #8832879 - Flags: review?(bugs) → review+

Comment 7

a year ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c7431468e5d
postMessages should have transferable as [] by default, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3d718ec7f07
transferables should be arrays of objects, r=smaug

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4c7431468e5d
https://hg.mozilla.org/mozilla-central/rev/c3d718ec7f07
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.