Closed
Bug 1336020
Opened 7 years ago
Closed 7 years ago
postMessages should have transferable as [] by default
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
Attachments
(2 files, 2 obsolete files)
|
25.44 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
|
30.56 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
This change should not impact web content.
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → amarchesini
Attachment #8832802 -
Flags: review?(bugs)
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8832802 -
Attachment description: transfer.patch → part 1 - default value for transferable sequence in postMessages
|
|
Assignee | |
Comment 2•7 years ago
|
||
Attachment #8832817 -
Flags: review?(bugs)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8832802 [details] [diff] [review] part 1 - default value for transferable sequence in postMessages So it doesn't matter that earlier we passed empty array to structured clone writing and now we pass undefined?
Attachment #8832802 -
Flags: review?(bugs) → review+
|
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8832817 [details] [diff] [review] part 2 - transferables should be 'object' in WebIDL So, this makes us always create array object. Even if there isn't any need. I'm pretty sure that would show up in microbenchmarks.
Attachment #8832817 -
Flags: review?(bugs) → review-
|
|
Assignee | |
Comment 5•7 years ago
|
||
Attachment #8832817 -
Attachment is obsolete: true
Attachment #8832867 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 6•7 years ago
|
||
Attachment #8832867 -
Attachment is obsolete: true
Attachment #8832867 -
Flags: review?(bugs)
Attachment #8832879 -
Flags: review?(bugs)
|
|
||
Updated•7 years ago
|
Attachment #8832879 -
Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4c7431468e5d postMessages should have transferable as [] by default, r=smaug https://hg.mozilla.org/integration/mozilla-inbound/rev/c3d718ec7f07 transferables should be arrays of objects, r=smaug
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4c7431468e5d https://hg.mozilla.org/mozilla-central/rev/c3d718ec7f07
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•