1336051 - [telemetry] inspector toolsidebar logs too many toolOpened events

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

STRs:
- (first you need some way to log telemetry logs)
- open devtools
- switch to inspector if inspector was not selected
(assuming the ruleview tab was selected in the inspector, but the same issue holds for any panel)

ER: Should have one DEVTOOLS_RULEVIEW_OPENED_COUNT event logged
AR: Two DEVTOOLS_RULEVIEW_OPENED_COUNT events are logged

Other STRs:
- open devtools
- switch to inspector if inspector was not selected
- click on the already selected sidebar tab X times

ER: Should have one DEVTOOLS_RULEVIEW_OPENED_COUNT event logged
AR: X+2 DEVTOOLS_RULEVIEW_OPENED_COUNT events are logged

The inspector toolsidebar should be improved to log telemtry events only when the current tool actually changes.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1336051 - fix telemetry logging for inspector toolsidebar;

Review commit: https://reviewboard.mozilla.org/r/109084/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109084/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8832834 [details]
Bug 1336051 - fix telemetry logging for inspector toolsidebar;

https://reviewboard.mozilla.org/r/109084/#review110564

The patch fixes the reported problem, thanks Julian!

Honza

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c488c8738ebe
fix telemetry logging for inspector toolsidebar;r=Honza

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c488c8738ebe