Closed Bug 1336056 Opened 8 years ago Closed 8 years ago

Ensure all tests pass on migrated Swift 3.0 code

Categories

(Firefox for iOS :: Build & Test, defect)

Product:
Firefox for iOS
Component:
Build & Test
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Iteration:
1.13

People

(Reporter: fluffyemily, Unassigned)

References

Details

(Whiteboard: [MobileCore] [Debt])

Attachments

(10 files)

AccountTests: SyncAuthStateTests -> testLive PR
55 bytes, text/x-github-pull-request
sleroux
: review+
farhan
: review+
Details | Review
Reading List Test Fixes PR
55 bytes, text/x-github-pull-request
farhan
: review+
farhan
: review+
Details | Review
StorageTests: TestSQLiteBookmarks tests fix PR
55 bytes, text/x-github-pull-request
farhan
: review+
farhan
: review+
Details | Review
StorageTests: TestSwiftData -> testFilledCursor PR
55 bytes, text/x-github-pull-request
farhan
: review+
farhan
: review+
Details | Review
TestsSQLIteHistory
55 bytes, text/x-github-pull-request
fluffyemily
: review+
Details | Review
MockSyncServerTests: testWipeStorage Pull Request
55 bytes, text/x-github-pull-request
farhan
: review+
Details | Review
StringExtensionTests - PR
55 bytes, text/x-github-pull-request
sleroux
: review+
Details | Review
webServerTests - PR
55 bytes, text/x-github-pull-request
Details | Review
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2387
55 bytes, text/x-github-pull-request
fluffyemily
: review+
Details | Review
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2388
55 bytes, text/x-github-pull-request
fluffyemily
: review+
Details | Review
Run unit tests and ensure they all still pass with migrated code
Account Tests: * SIGABRT in SyncAuthStateTests: testLive ReadingListTests: * ReadingListClientRecordTestCase: testInitWithRow, testInitWithRowWithoutServerMeta, testJSON * ReadingListStorageTestCase: testCreateRecord StorageTests: * TestSQLLiteBookmarks: all tests * TestSQLIteHistory: testHistoryLocalAndRemoteVisits, testDomainUpgrade, testDomains, testHistoryIsSynced, testHistoryTable, testTopSitesCache * TestSQLHistoryFilterSplitting: * TestSQLiteHistoryRecommendations: testHistoryHighlights, testBookmarkHighlights, testMostRecentUniqueDoimainReturnedInHighlights * TestSQLiteHistoryRecommendationsPerf: * TestSQLIteLogins: testAddLogin, testGetOrder, testRemoveLogins, testRemoveManyLogins, testUpdateLogin, testSearchLogin * TestSQLIteMetadata: testExpirationPurging * TestSwiftData: testFilledCursor * TestSyncableLogins: testLocalNewStaysNewAndIsRemoved, testApplyLogin, testLoginsIsSynced SyncTests: * LiveStorageClientTests: * MetaGlobalTests: * MockSyncServerTests: testWipeStorage, testPut * TestBookmarkModel * TestBookmarkTreeMerging: ClientTests: * AuthenticatorTests: * ClientTests: testDisallowLocalhostAliases * StringExtensionsTests: testContains, testStringSplitWithNewline * TestBookmarks * TestHistory: testHistory, testGetPerformance * UIImageViewExtensionsTests: testAsyncSetIcon * WebServerTests: testWebServerIsServingRequests
Test fixes for AccountTests: SyncAuthStateTests -> testLive
Attachment #8833278 - Flags: review?(sleroux)
Attachment #8833278 - Flags: review?(fpatel)
Attachment #8833283 - Flags: review?(sleroux)
Attachment #8833283 - Flags: review?(fpatel)
Comment on attachment 8833283 [details] [review] Reading List Test Fixes PR Resolves: * ReadingListClientRecordTestCase: testInitWithRow, testInitWithRowWithoutServerMeta, testJSON * ReadingListStorageTestCase: testCreateRecord
Attachment #8833278 - Flags: review?(sleroux) → review+
Resolves: TestSQLLiteBookmarks: all tests
Attachment #8833295 - Flags: review?(sleroux)
Attachment #8833295 - Flags: review?(fpatel)
Comment on attachment 8833295 [details] [review] StorageTests: TestSQLiteBookmarks tests fix PR also resolves: * TestSQLIteHistory: testTopSitesCache * TestSQLIteLogins: testAddLogin, testGetOrder, testRemoveLogins, testRemoveManyLogins, testUpdateLogin, testSearchLogin * TestSyncableLogins: testLocalNewStaysNewAndIsRemoved, testApplyLogin, testLoginsIsSynced
Comment on attachment 8833295 [details] [review] StorageTests: TestSQLiteBookmarks tests fix PR * TestSQLIteMetadata: testExpirationPurging
Attachment #8833314 - Flags: review?(sleroux)
Attachment #8833314 - Flags: review?(fpatel)
Attached file TestsSQLIteHistory —
Attachment #8833326 - Flags: review?(etoop)
Comment on attachment 8833336 [details] [review] MockSyncServerTests: testWipeStorage Pull Request Fixes * MockSyncServerTests: testWipeStorage
Attachment #8833283 - Flags: review?(sleroux)
Attachment #8833283 - Flags: review?(fpatel)
Attachment #8833283 - Flags: review+
Attachment #8833336 - Flags: review?(fpatel) → review+
Attachment #8833314 - Flags: review?(sleroux)
Attachment #8833314 - Flags: review?(fpatel)
Attachment #8833314 - Flags: review+
Attachment #8833295 - Flags: review?(sleroux)
Attachment #8833295 - Flags: review?(fpatel)
Attachment #8833295 - Flags: review+
Attachment #8833278 - Flags: review?(fpatel) → review+
Attachment #8833326 - Flags: review?(etoop) → review+
Attachment #8833976 - Flags: review?(sleroux)
Attachment #8833976 - Flags: review?(sleroux) → review+
Attached file webServerTests - PR —
Attachment #8833977 - Flags: review?(sleroux)
Attachment #8834017 - Flags: review?(etoop) → review+
Attachment #8834019 - Flags: review?(etoop) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Attachment #8833977 - Flags: review?(sleroux)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: