1336090 - pushlog data empty when using searches

Status: RESOLVED FIXED

(Developer Services :: Mercurial: Pushlog, defect)

Description

[Axel Hecht [:Pike]]

When looking at what we get on the web and json for searches in changelog, I noticed that the pushlog data is empty.

See https://hg.mozilla.org/releases/l10n/mozilla-beta/de/changelog?rev=limit(sort(branch(default),%20-rev)) or https://hg.mozilla.org/releases/l10n/mozilla-beta/de/json-changelog?rev=limit(sort(branch(default),%20-rev)).

The culprit is that for searches, webcommands uses the searchentry template. That has the right entries, but it uses webutil.commonentry as entry type, and pushlog doesn't overwrite that.

Now, it can, and that makes overwriting each of changesetentry and changelistentry obsolete.

I have a patch for that. no-docker tests pass with hg 4.0.1.

I dug a bit into the history of commonentry, https://www.mercurial-scm.org/repo/hg/diff/5aa2afb4f81a/mercurial/hgweb/webutil.py introduced that November 2015, so we should be good in terms of mercurial versions? 3.7 was released 2016-02-01

I tried running the tests against 3.7, but they fail for hgmo being 4.0 only. Should the claim about compat in pushlog/__init__.py be lifted?

Comment 1

[Axel Hecht [:Pike]]

Attachment: bug 1336090, wrap webutil.commonentry to add push metadata,

Previously, we wrapped both changelistentry and changesetentry,
which makes searches on the web not get pushlog data, as that's
using commonentry directly.
As both changelistentry and changesetentry base off of commonentry,
let's just wrap that.

commonentry was introduced in hg in https://www.mercurial-scm.org/repo/hg/diff/5aa2afb4f81a/mercurial/hgweb/webutil.py.

Review commit: https://reviewboard.mozilla.org/r/109124/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109124/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8832863 [details]
bug 1336090, wrap webutil.commonentry to add push metadata,

https://reviewboard.mozilla.org/r/109124/#review110310

Nice improvement.

Yes, we should update testedwith. I'll do that as a follow-up.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/3912a52b8945
wrap webutil.commonentry to add push metadata, r=gps

Comment 4

[Gregory Szorc [:gps]]

Oh, it looks like the test issue is related to the hgmo extension and not pushlog itself. I may or may not clean this up. It appears to only be a problem with the test environment, since it loads the hgmo extension.

Comment 5

[Gregory Szorc [:gps]]

This is now deployed. I verified from the URLs in comment #0 that it is working.