Closed Bug 1336140 Opened 7 years ago Closed 7 years ago

Add-on sdk's childProcess.spawn() API failing on Windows XP in Fx51

Categories

(Add-on SDK Graveyard :: General, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(firefox54 wontfix)

RESOLVED DUPLICATE of bug 1334503
Tracking Status
firefox54 --- wontfix

People

(Reporter: jimm, Unassigned)

References

()

Details

(Keywords: regression, regressionwindow-wanted, Whiteboard: [platform-rel-Symantec][platform-rel-Norton])

Issue reported with this API in Fx51 where the spawn succeeds but the child process fails to connect up proerly wit the parent, which in some add-ons can result in numerous childs process getting launched, consuming system resources.

https://community.norton.com/en/forums/task-manager-gone-mad-conathstexe

Some data points:
- only happens on XP SP3.
- Failure is “Failed to attach process to job” which appears to be related to the code calling AssignProcessToJobObject and getting “access denied”.
- not related to sandboxing or e10s which isn't enabled for these users

We don't have a lot of devs internally who can test for this. Benjamin, can softvision help us out here with an attempt to reproduce and a regression range search?
Flags: needinfo?(benjamin)
platform-rel: --- → +
Whiteboard: [platform-rel-Symantec][platform-rel-Norton]
We presumably have access to at least some XP VMs. But if you're asking SV to provide a regression range, can we create some sort of minimal testcase addon so that they can easily run the regression? Having to check task manager for a production addon sounds tricky.

According to AssignProcessToJobObject docs: "Windows 7, Windows Server 2008 R2, Windows XP with SP3, Windows Server 2008, Windows Vista and Windows Server 2003:  The process must not already be assigned to a job; if it is, the function fails with ERROR_ACCESS_DENIED. This behavior changed starting in Windows 8 and Windows Server 2012."

We have automated tests for subprocess.jsm at toolkit/modules/subprocess/test/xpcshell/test_subprocess.js. Are those being run/passing on windows xp? Kris Maglione wrote this module and test, so I think he'd be the best engineering lead to look at this.
platform-rel: + → ---
Flags: needinfo?(benjamin) → needinfo?(kmaglione+bmo)
Product: Core → Add-on SDK
Version: Trunk → unspecified
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Flags: needinfo?(kmaglione+bmo)
Per bug 1334503, mark 54 won't fix.
You need to log in before you can comment on or make changes to this bug.