Closed Bug 1336202 Opened 3 years ago Closed 3 years ago

Make the test updater compatible with artifact builds

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The bits to install the test updater in http://searchfox.org/mozilla-central/source/toolkit/mozapps/update/updater/updater-xpcshell/Makefile.in aren't visible to artifact builds, so tests relying on it fail.
Comment on attachment 8833427 [details]
Bug 1336202 - Fix installation of the test updater.

https://reviewboard.mozilla.org/r/109662/#review111212

::: toolkit/mozapps/update/updater/updater-xpcshell/Makefile.in
(Diff revision 1)
>  else
>  MOZ_WINCONSOLE = 0
>  endif
>  endif
>  
> -ifdef COMPILE_ENVIRONMENT

Do we need to land this patch with the ifdef intact first so that the test packages that an artifact build might download will contain updater-xpcshell? Or are we ok with a window of time where people might do an artifact build and grab an older revision? As-is the build fails if your tests.zip file doesn't have updater-xpcshell.
Attachment #8833427 - Flags: review?(mshal) → review+
Comment on attachment 8833427 [details]
Bug 1336202 - Fix installation of the test updater.

https://reviewboard.mozilla.org/r/109662/#review111212

> Do we need to land this patch with the ifdef intact first so that the test packages that an artifact build might download will contain updater-xpcshell? Or are we ok with a window of time where people might do an artifact build and grab an older revision? As-is the build fails if your tests.zip file doesn't have updater-xpcshell.

That's a good call... this shouldn't be too much of an issue, but it could cause some confusion, and will leave automation in limbo for a bit, so I'll split that out.
Keywords: leave-open
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5619be2962c6
Install the test updater to the test package by setting FINAL_TARGET in moz.build. r=mshal
Comment on attachment 8834127 [details]
Bug 1336202 - Install the test updater during artifact builds.

https://reviewboard.mozilla.org/r/110174/#review111248
Attachment #8834127 - Flags: review?(mshal) → review+
Comment on attachment 8833427 [details]
Bug 1336202 - Fix installation of the test updater.

https://reviewboard.mozilla.org/r/109662/#review111802
Attachment #8833427 - Flags: review?(robert.strong.bugs) → review+
Keywords: leave-open
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4dc48e5a94e
Fix installation of the test updater. r=rstrong
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1c77801884d
Install the test updater during artifact builds. r=mshal
https://hg.mozilla.org/mozilla-central/rev/c4dc48e5a94e
https://hg.mozilla.org/mozilla-central/rev/e1c77801884d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.