Proxy the __lbheartbeat__ route through nginx to tornado

RESOLVED FIXED

Status

Conduit
General
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: imadueme, Assigned: imadueme)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1334498 added the __lbheartbeat__ end point on the tornado API. When connecting directly to the tornado server, this route works perfectly.

When the tornado server is proxied behind nginx, this route is unreachable. This is because the nginx by default only proxies urls prefixed with /api/ to the tornado server.

Nginx should also proxy /__lbheartbeat__ to the tornado server.
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8833061 [details]
autoland: update nginx location to also proxy /__lbheartbeat__ to tornado (bug 1336210).

https://reviewboard.mozilla.org/r/109288/#review110724

Tested locally, LGTM
Attachment #8833061 - Flags: review?(mars) → review+

Comment 3

a year ago
mozreview-review
Comment on attachment 8833061 [details]
autoland: update nginx location to also proxy /__lbheartbeat__ to tornado (bug 1336210).

https://reviewboard.mozilla.org/r/109288/#review111588

::: autoland/docker/web/nginx-conf.d/default.conf:10
(Diff revision 1)
>      location / {
>          proxy_pass  http://yarn:4000/;
>      }
>  
>      # Proxy requests to the autoland backing service
> -    location ~ /api/.* {
> +    location ~ (/api/.*|__lbheartbeat__) {

Will this match on `/__lbheartbeat__/` (trialing slash) as well? if not please fix in a followup.
Attachment #8833061 - Flags: review?(smacleod) → review+

Comment 4

a year ago
Pushed by smacleod@mozilla.com:
https://hg.mozilla.org/automation/conduit/rev/f1e213a00938
autoland: update nginx location to also proxy /__lbheartbeat__ to tornado . r=mars,smacleod
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(Assignee)

Comment 5

a year ago
mozreview-review-reply
Comment on attachment 8833061 [details]
autoland: update nginx location to also proxy /__lbheartbeat__ to tornado (bug 1336210).

https://reviewboard.mozilla.org/r/109288/#review111588

> Will this match on `/__lbheartbeat__/` (trialing slash) as well? if not please fix in a followup.

I confirmed that it indeed matches both `/__lbheartbeat__` and ` /__lbheartbeat__/`

Updated

a year ago
Assignee: nobody → imadueme
You need to log in before you can comment on or make changes to this bug.