When a window is maximized, it should not show the window opening transition

RESOLVED FIXED in Firefox 54

Status

()

Core
Widget: Win32
RESOLVED FIXED
6 months ago
2 months ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

(Blocks: 1 bug)

50 Branch
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

As part of our efforts to improve perceived performance, one of the things that the UX team has identified coming out of the Photon work is that we want the opening of new windows to feel smooth.

On Windows, at least, there is a default "effect" that makes the window "fade in" and zoom. At least for maximized windows, the UX team feels that this effect just takes valuable time and can get axed.
I've looked at this briefly, and I _suspect_ it's pretty straight forward. Gonna try this today.
Assignee: nobody → mconley
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
So we already had a feature flag for windows to prevent animation on MacOS. I've made that agnostic, and written the JavaScript that checks the window state for STATE_MAXIMIZED and adds that feature flag if the window is indeed maximized.

Basically, what I've got here is the behaviour that's been described, but on MacOS. Not sure if we want it there, but that's where I started. Now I'm going to try to get the suppressanimation feature supported for our Windows backend.
Do we want this change on MacOS as well as Windows?
Flags: needinfo?(philipp)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Is that the same effect used on browser startup when sessionrestore is restoring the windows?
(In reply to :Felipe Gomes (needinfo me!) from comment #9)
> Is that the same effect used on browser startup when sessionrestore is
> restoring the windows?

Yes. A consequence (or benefit?) of the patches here is that on Windows, we'll stop animating the windows that are opened on session restore.

Comment 11

6 months ago
mozreview-review
Comment on attachment 8833479 [details]
Bug 1336230 - Rename macsuppressanimation and CHROME_MAC_SUPPRESS_ANIMATION to be platform agnostic.

https://reviewboard.mozilla.org/r/109728/#review111124
Attachment #8833479 - Flags: review?(jmathies) → review+

Comment 12

6 months ago
mozreview-review
Comment on attachment 8833524 [details]
Bug 1336230 - Add suppressanimation support to Windows backend.

https://reviewboard.mozilla.org/r/109748/#review111128
Attachment #8833524 - Flags: review?(jmathies) → review+

Comment 13

6 months ago
mozreview-review
Comment on attachment 8833480 [details]
Bug 1336230 - If the current window is maximized if the user opens a new window, skip the opening animation.

https://reviewboard.mozilla.org/r/109730/#review110862
Attachment #8833480 - Flags: review?(felipc) → review+

Comment 14

6 months ago
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/48c77c39e587
Rename macsuppressanimation and CHROME_MAC_SUPPRESS_ANIMATION to be platform agnostic. r=jimm
https://hg.mozilla.org/integration/autoland/rev/768bf846fac5
Add suppressanimation support to Windows backend. r=jimm
https://hg.mozilla.org/integration/autoland/rev/16dc1c594448
If the current window is maximized if the user opens a new window, skip the opening animation. r=Felipe

Comment 15

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/48c77c39e587
https://hg.mozilla.org/mozilla-central/rev/768bf846fac5
https://hg.mozilla.org/mozilla-central/rev/16dc1c594448
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Looks good!
As just discussed in person, let's enable the fix on all platforms.
Flags: needinfo?(philipp)
In toolkit/components/windowwatcher/test/browser_new_content_window_chromeflags.js

> -  "macsuppressanimation": {
> +  "suppressanimation": {
>      flag: Ci.nsIWebBrowserChrome.CHROME_MAC_SUPPRESS_ANIMATION,

Shouldn't this be:

> -  "macsuppressanimation": {
> -    flag: Ci.nsIWebBrowserChrome.CHROME_MAC_SUPPRESS_ANIMATION,
> +  "suppressanimation": {
> +    flag: Ci.nsIWebBrowserChrome.CHROME_SUPPRESS_ANIMATION,
Blocks: 1337432
(In reply to Frank-Rainer Grahl from comment #17)
> In
> toolkit/components/windowwatcher/test/browser_new_content_window_chromeflags.
> js
> 
> > -  "macsuppressanimation": {
> > +  "suppressanimation": {
> >      flag: Ci.nsIWebBrowserChrome.CHROME_MAC_SUPPRESS_ANIMATION,
> 
> Shouldn't this be:
> 
> > -  "macsuppressanimation": {
> > -    flag: Ci.nsIWebBrowserChrome.CHROME_MAC_SUPPRESS_ANIMATION,
> > +  "suppressanimation": {
> > +    flag: Ci.nsIWebBrowserChrome.CHROME_SUPPRESS_ANIMATION,

Yep, definitely. Good eye, thanks. I've filed bug 1337432 to address this.

Updated

4 months ago
Blocks: 1348289
No longer blocks: 1325171
Blocks: 1362103
No longer blocks: 1348289
Blocks: 1348289
See Also: → bug 1331932
You need to log in before you can comment on or make changes to this bug.