1336249 - Improve and Add More UI Testing

Status: RESOLVED FIXED

(Conduit :: General, defect)

Description

[David Walsh :davidwalsh]

At present we have a few very basic tests but we should improve that.  We should add some route testing and various other tests for other components.

Comment 1

[David Walsh :davidwalsh]

Attachment: autoland-ui: Improve tests for ActionButtons by ensuring the land button functions properly. (Bug 1336249)

Review commit: https://reviewboard.mozilla.org/r/109714/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109714/

Comment 2

[David Walsh :davidwalsh]

Attachment: autoland-ui: Create Route tests as well as ensure babel works properly within jest (Bug 1336249).

Review commit: https://reviewboard.mozilla.org/r/109716/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109716/

Comment 3

[David Walsh :davidwalsh]

Attachment: autoland-ui: Create AutolandController tests (Bug 1336249).

Review commit: https://reviewboard.mozilla.org/r/109718/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109718/

Comment 4

[David Walsh :davidwalsh]

Comment on attachment 8833465 [details]
autoland-ui: Create Route tests as well as ensure babel works properly within jest (Bug 1336249).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/109716/diff/1-2/

Comment 5

[David Walsh :davidwalsh]

Comment on attachment 8833466 [details]
autoland-ui: Create AutolandController tests (Bug 1336249).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/109718/diff/1-2/

Comment 6

[Israel Madueme [:imadueme]]

Comment on attachment 8833464 [details]
autoland-ui: Improve tests for ActionButtons by ensuring the land button functions properly. (Bug 1336249)

https://reviewboard.mozilla.org/r/109714/#review110762

:thumbsup:

Comment 7

[Israel Madueme [:imadueme]]

Comment on attachment 8833465 [details]
autoland-ui: Create Route tests as well as ensure babel works properly within jest (Bug 1336249).

https://reviewboard.mozilla.org/r/109716/#review110764

::: autoland/ui/src/components/AutolandController.jsx:14
(Diff revision 2)
> +
> +  defaultState = { data: null, error: null };
> +
>    constructor(props) {
>      super(props);
> -    this.state = this.getInitialState();
> +    this.state = this.defaultState;

Any reason for not putting this as a field at the top like in your gist?

Comment 8

[Israel Madueme [:imadueme]]

Comment on attachment 8833466 [details]
autoland-ui: Create AutolandController tests (Bug 1336249).

https://reviewboard.mozilla.org/r/109718/#review110766

::: autoland/ui/src/components/AutolandController.jsx:85
(Diff revision 2)
>      }
>  
>      // This is the default text for the element while we fetch data
>      // during the initial widget creation
>      if (data === null) {
> -      return <span>Fetching data...</span>;
> +      return <span className="fetching-data">Fetching data...</span>;

Hopefully our css names don't start conflicting...

Comment 9

[David Walsh :davidwalsh]

Comment on attachment 8833465 [details]
autoland-ui: Create Route tests as well as ensure babel works properly within jest (Bug 1336249).

https://reviewboard.mozilla.org/r/109716/#review110764

> Any reason for not putting this as a field at the top like in your gist?

While it's cute to do this, using `this` outside of a method seems dirty.  :/

Comment 10

[Steven MacLeod [:smacleod]]

Comment on attachment 8833464 [details]
autoland-ui: Improve tests for ActionButtons by ensuring the land button functions properly. (Bug 1336249)

https://reviewboard.mozilla.org/r/109714/#review111636

Comment 11

[Steven MacLeod [:smacleod]]

Comment on attachment 8833465 [details]
autoland-ui: Create Route tests as well as ensure babel works properly within jest (Bug 1336249).

https://reviewboard.mozilla.org/r/109716/#review111644

Comment 12

[Steven MacLeod [:smacleod]]

Comment on attachment 8833466 [details]
autoland-ui: Create AutolandController tests (Bug 1336249).

https://reviewboard.mozilla.org/r/109718/#review111646

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/automation/conduit/rev/cf4595460e76
autoland-ui: Improve tests for ActionButtons by ensuring the land button functions properly. r=imadueme,smacleod
https://hg.mozilla.org/automation/conduit/rev/399a155c565d
autoland-ui: Create Route tests as well as ensure babel works properly within jest . r=imadueme,smacleod
https://hg.mozilla.org/automation/conduit/rev/8ec8bab82a62
autoland-ui: Create AutolandController tests . r=imadueme,smacleod