1336276 - HTTP 500 for TemplateSyntaxError not showing up in New Relic

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Ed Morley [:emorley]]

I'm pretty sure HTTP 500s used to show in New Relic, however the exception seen in bug 1336270 didn't show up there, and I had to hunt for it in papertrail instead :-/

Comment 1

[Ed Morley [:emorley]]

I've managed to reproduce locally (took quite a while, was lead down a wrong track due to the agent buffering audit log output between harvest cycles), and have created a reduced testcase and filed a New Relic ticket (is an upstream Python agent bug):

https://github.com/edmorley/newrelic-template-testcase
https://support.newrelic.com/tickets/232437/edit

Comment 2

[Ed Morley [:emorley]]

Reply from New Relic:

"""
Thank you for the repro case! We have made a few changes recently around Flask and Django class-based transaction naming, but have not addressed exceptions recently. While your last ticket to us did not have a workaround, this issue may.

I am going to start the investigation process and will follow up with you next week after we get a chance to discuss this in detail with the rest of the team.
...
"""

Comment 3

[Ed Morley [:emorley]]

Follow-up reply from New Relic:

"""
Thanks again for the follow up and all the information we needed to reproduce this issue. Our engineering team has exactly what they need and has already started on a fix for this issue! Once we get it sorted out and released, we will notify you.

As always, thank you for being an all-star customer and taking on so much of the legwork when tracking down these issues with the agent. We all appericate it very, very much. Since we expect to resolve this in a future agent release, I will close this ticket now, but replying will reopen it.
"""

Comment 4

[Ed Morley [:emorley]]

This has now been fixed in v2.82.0.62:
https://docs.newrelic.com/docs/release-notes/agent-release-notes/python-release-notes/python-agent-282062

Comment 5

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:newrelic-2.82.0.62 > mozilla:master

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/dfb82632f92a9287ed783bbd7ab52fff8ff7b38a
Bug 1336276 - Update newrelic from 2.78.0.57 to 2.82.0.62

Notably this fixes the reporting of exceptions that occur outside of a
view handler (which previously did not show up in APM at all).

https://docs.newrelic.com/docs/release-notes/agent-release-notes/python-release-notes/python-agent-282062
https://github.com/edmorley/newrelic-python-agent/compare/v2.78.0.57...v2.82.0.62