Remove ImageBridgeThread

RESOLVED FIXED in Firefox 54

Status

()

Core
Graphics: Layers
--
critical
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: njn, Assigned: njn)

Tracking

Trunk
mozilla54
Points:
---

Firefox Tracking Flags

(firefox52 wontfix, firefox53 wontfix, firefox54 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 months ago
This class is a temporary hack that was added to avoid a spurious LSan warning on Beta/Release. It has not been necessary since bug 1215265 landed.
(Assignee)

Comment 1

9 months ago
Created attachment 8833128 [details] [diff] [review]
Remove ImageBridgeChild

Try push (done from a mozilla-beta clone) looks good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=979efd7e32e9f7978c1c8e2c39937c83e85c2078
Attachment #8833128 - Flags: review?(ttromey)
(Assignee)

Updated

9 months ago
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
You are removing ImageBridgeThread, not ImageBridgeChild. I was confused by the summary of the bug. ;)
Summary: Remove ImageBridgeChild → Remove ImageBridgeThread
(Assignee)

Comment 3

9 months ago
Created attachment 8833166 [details] [diff] [review]
Remove ImageBridgeThread

Indeed! Well spotted.
Attachment #8833166 - Flags: review?(ttromey)
(Assignee)

Updated

9 months ago
Attachment #8833128 - Attachment is obsolete: true
Attachment #8833128 - Flags: review?(ttromey)

Comment 4

9 months ago
Comment on attachment 8833166 [details] [diff] [review]
Remove ImageBridgeThread

Review of attachment 8833166 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for doing this.  It looks good to me.
Attachment #8833166 - Flags: review?(ttromey) → review+
(Assignee)

Comment 5

9 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a778feca18c9feb4187095916f869497c37bc5b
Bug 1336288 - Remove ImageBridgeThread. r=ttromey.

Comment 6

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0a778feca18c
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Do we need/want this on Aurora/Beta as well? If so, please nominate :)
status-firefox52: --- → affected
status-firefox53: --- → affected
(Assignee)

Comment 8

9 months ago
> Do we need/want this on Aurora/Beta as well? If so, please nominate :)

No need. It's a small code improvement but doesn't have any notable side-effects.
status-firefox52: affected → wontfix
status-firefox53: affected → wontfix
Keywords: mlk
(Assignee)

Updated

9 months ago
status-firefox52: wontfix → affected
status-firefox53: wontfix → affected
(Assignee)

Updated

9 months ago
status-firefox52: affected → wontfix
status-firefox53: affected → wontfix
You need to log in before you can comment on or make changes to this bug.