Closed Bug 1336288 Opened 5 years ago Closed 5 years ago

Remove ImageBridgeThread

Categories

(Core :: Graphics: Layers, defect)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox52 --- wontfix
firefox53 --- wontfix
firefox54 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

Details

Attachments

(1 file, 1 obsolete file)

This class is a temporary hack that was added to avoid a spurious LSan warning on Beta/Release. It has not been necessary since bug 1215265 landed.
Attached patch Remove ImageBridgeChild (obsolete) — Splinter Review
Try push (done from a mozilla-beta clone) looks good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=979efd7e32e9f7978c1c8e2c39937c83e85c2078
Attachment #8833128 - Flags: review?(ttromey)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
You are removing ImageBridgeThread, not ImageBridgeChild. I was confused by the summary of the bug. ;)
Summary: Remove ImageBridgeChild → Remove ImageBridgeThread
Indeed! Well spotted.
Attachment #8833166 - Flags: review?(ttromey)
Attachment #8833128 - Attachment is obsolete: true
Attachment #8833128 - Flags: review?(ttromey)
Comment on attachment 8833166 [details] [diff] [review]
Remove ImageBridgeThread

Review of attachment 8833166 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for doing this.  It looks good to me.
Attachment #8833166 - Flags: review?(ttromey) → review+
https://hg.mozilla.org/mozilla-central/rev/0a778feca18c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Do we need/want this on Aurora/Beta as well? If so, please nominate :)
> Do we need/want this on Aurora/Beta as well? If so, please nominate :)

No need. It's a small code improvement but doesn't have any notable side-effects.
You need to log in before you can comment on or make changes to this bug.