1336291 - Lots of "TypeError: this._browsers is null: _getBrowserRefs@resource://app/modules/NewTabWebChannel.jsm:149" logspam during browser_remotenewtab_pageloads.js

Status: VERIFIED FIXED

Description

[Ryan VanderMeulen [:RyanVM]]

This is a really spammy message while this test is running. Affects all current branches.
https://treeherder.mozilla.org/logviewer.html#?job_id=74137204&repo=mozilla-beta&lineNumber=3516

Looking at the blame of the file, I'm not even sure who's around to look at this anymore. Kate, can you maybe take a look or suggest someone else who might?

Comment 1

[Sebastian Hengst [PTO+professional development; back to normal activity 2019-02-25][:aryx] (needinfo on intermittent or backout)]

Regression from bug 1320481.

This is problematic because the error can occur so often that other failures aren't part of the error summary for a job on treeherder anymore and one has to open and search the raw log.

Comment 2

[Marco Bonardo [::mak]]

Created attachment 8834048 [details]
Bug 1336291 - Lots of 'TypeError: this._browsers is null' browser_remotenewtab_pageloads.js.

Review commit: https://reviewboard.mozilla.org/r/110146/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110146/

Comment 3

[Marco Bonardo [::mak]]

The problem is that frecency changes can send notifications quite late on shutdown, new tab receives the notification and tries to handle it.
This is mostly a stopgap fix, I don't think we should go much further honestly.

Comment 4

[:Felipe Gomes (needinfo me!)]

Comment on attachment 8834048 [details]
Bug 1336291 - Lots of 'TypeError: this._browsers is null' browser_remotenewtab_pageloads.js.

https://reviewboard.mozilla.org/r/110146/#review111192

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec06d5263eb3
Lots of 'TypeError: this._browsers is null' browser_remotenewtab_pageloads.js. r=Felipe

Comment 6

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/ec06d5263eb3

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Confirmed that the spam is gone. Please request Aurora/Beta approval on this when you get a chance.

Comment 8

[Marco Bonardo [::mak]]

Comment on attachment 8834048 [details]
Bug 1336291 - Lots of 'TypeError: this._browsers is null' browser_remotenewtab_pageloads.js.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1320481 
[User impact if declined]: No users impact, but lots of spam in test runs that impacts sheriffs and developers
[Is this code covered by automated tests?]: not this specific fix
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple early return
[String changes made/needed]: none

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 8834048 [details]
Bug 1336291 - Lots of 'TypeError: this._browsers is null' browser_remotenewtab_pageloads.js.

early return to fix test log spam, aurora53+, beta52+

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/056b0e09741c

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e6c3c117e08b

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/e6c3c117e08b