Closed Bug 1336393 Opened 3 years ago Closed 3 years ago

about:support on Android should not have a button to launch Firefox in Safe-Mode

Categories

(Toolkit :: Startup and Profile System, defect)

Unspecified
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox51 --- wontfix
firefox52 --- wontfix
firefox53 --- affected
firefox54 --- fixed

People

(Reporter: tomer, Assigned: tomer, NeedInfo)

References

Details

Attachments

(1 file)

Similar to bug 1332625, there should not be a UI option to launch Firefox in safe mode on Android, so there is no need for the button. 

Steps to reproduce:
a. Open about:support on Android.
b. Click the button to launch Firefox in safe mode with addons disabled. 


Actual result:
Nothing happen.

Expected result:
Implement the feature or have the button disappear.


This problem affects all versions of Firefox for Android, from release to nightly.
Attachment #8833266 - Flags: review?(standard8)
Comment on attachment 8833266 [details]
Bug 1336393 - about:support on Android should not have a button to launch Firefox in Safe-Mode

https://reviewboard.mozilla.org/r/109516/#review111084

::: toolkit/content/aboutSupport.xhtml:48
(Diff revision 1)
>          <h3>&aboutSupport.safeModeTitle;</h3>
>          <button id="restart-in-safe-mode-button">
>            &aboutSupport.restartInSafeMode.label;
>          </button>
>        </div>
> +#endif

This endif is too high - needs moving down until after the next </div>
Attachment #8833266 - Flags: review?(standard8)
Comment on attachment 8833266 [details]
Bug 1336393 - about:support on Android should not have a button to launch Firefox in Safe-Mode

https://reviewboard.mozilla.org/r/109516/#review111088

::: toolkit/content/aboutSupport.xhtml:48
(Diff revision 1)
>          <h3>&aboutSupport.safeModeTitle;</h3>
>          <button id="restart-in-safe-mode-button">
>            &aboutSupport.restartInSafeMode.label;
>          </button>
>        </div>
> +#endif

Sorry. will fix it right away.
Comment on attachment 8833266 [details]
Bug 1336393 - about:support on Android should not have a button to launch Firefox in Safe-Mode

https://reviewboard.mozilla.org/r/109516/#review111926

Thanks. Looks good. r=Standard8
Attachment #8833266 - Flags: review?(standard8) → review+
Assignee: nobody → tomer.moz.bugs
Status: NEW → ASSIGNED
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1753b56f12e9
about:support on Android should not have a button to launch Firefox in Safe-Mode r=standard8
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1753b56f12e9
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
I can confirm this is fixed on latest Nightly.
Too late for 51. Mark 51 won't fix.

Hi :tomer,
Do you think this is worth uplifting to aurora at least if the patch is not too risky?
Flags: needinfo?(tomer.moz.bugs)
You need to log in before you can comment on or make changes to this bug.