Closed Bug 1336396 Opened 6 years ago Closed 6 years ago

1px difference visible when hovering the 'Show your bookmarks' and 'Bookmark this page' buttons on non-round-int dppx (1.25, 1.5, 2.5, ... but not 2x)

Categories

(Firefox :: Theme, defect, P3)

defect

Tracking

()

RESOLVED INVALID

People

(Reporter: itiel_yn8, Unassigned, Mentored)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Attached image Screenshot
STR:
1. Change Windows DPI to higher than 125%
2. Open Firefox
3. Hover the one of the 'Show your bookmarks' and 'Bookmark this page' buttons

Actual results:
There's a 1px difference between the 2 buttons

Expected results:
There shouldn't be.

See attached screenshot.
Component: General → XUL
Product: Firefox → Core
This will be a styling artifact.
Component: XUL → Theme
Product: Core → Firefox
200% is unaffected for me but 250% is affected, so it seems to be limited to non-int scales. My gut tells me bug 477157 is probably involved.
(In reply to Greg Edwards from comment #2)
> 200% is unaffected for me but 250% is affected, so it seems to be limited to
> non-int scales. My gut tells me bug 477157 is probably involved.

Possibly, or a mis-sized icon, or something else. Either way, this should be fixable in theme code.

I can mentor someone to work on this, but I don't have cycles to investigate it myself. The first step would be to use the browser toolbox to investigate exactly what is going on.
Mentor: gijskruitbosch+bugs
Priority: -- → P3
Summary: 1px difference visible when hovering the 'Show your bookmarks' and 'Bookmark this page' buttons if DPI > 125% → 1px difference visible when hovering the 'Show your bookmarks' and 'Bookmark this page' buttons on non-round-int dppx (1.25, 1.5, 2.5, ... but not 2x)
No longer relevant as the buttons are one now.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.