1336426 - Three finger tap should should use text selection as a source for dict query

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Stefan Plewako [:stef]]

New York

If I select above and make three finger tap I get results for "New" or "York" on Firefox on my mac but never for "New York". Another example (always "don"): don't

Comment 1

[Vitaly Kravchenko]

It's not just the tap that doesn't work for text selection, but the Cmd+Ctrl+D shortcut as well. The shortcut will only work if your mouse cursor is over a word. And it will work for just that word, not the selected phrase. If your cursor is above a space between words, that space will be looked up in the dictionary.

Comment 2

[Poren Chiang [:RSChiang]]

Attachment: Bug 1336426 - Query selected text before calling word breaker.

Signed-off-by: Poren Chiang <[e-mail]>

Comment 3

[Poren Chiang [:RSChiang]]

So I whipped up a patch upon the latest Nightly build, tested against macOS 10.14.6.

Upon applying this patch, user selected text would be honored in force-press dictionary lookup if the cursor position is within current selection. This is the behavior that native TextEdit.app has exhibited.

(CC :masayuki for reviewing the patch!)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f56cb5f07338
Query selected text before calling word breaker. r=masayuki,m_kato

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/f56cb5f07338

Comment 6

[Ciprian Georgiu, Desktop QA]

Reproduced this issue on macOS 10.15, on an affected Nightly build 2020-03-20.

The issue is verified as fixed on latest Beta 76.0b4. The issue is not reproducing anymore when using both, the shortcut or the three finger option.