Closed Bug 1336515 Opened 3 years ago Closed 3 years ago

Assertion in TIPMessageHandler instantiation on non-touchscreen device

Categories

(Core :: Widget: Win32, defect)

Unspecified
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox52 --- fixed
firefox-esr52 --- fixed
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

Details

Attachments

(1 file)

See https://bugzilla.mozilla.org/show_bug.cgi?id=1330460#c1

I think the problem here is that, on non-touchscreen devices, tiptsf.dll won't be present.
Sorry for commenting in bug 1330460 instead of filing a new one. I thought bug 1330460 would also fix my problem.
Comment on attachment 8833432 [details]
Bug 1336515: Fix assertions in TIPMessageHandler instantiation on non-touchscreen devices;

https://reviewboard.mozilla.org/r/109666/#review111120
Attachment #8833432 - Flags: review?(jmathies) → review+
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e54a95d4fec3
Fix assertions in TIPMessageHandler instantiation on non-touchscreen devices; r=jimm
https://hg.mozilla.org/mozilla-central/rev/e54a95d4fec3
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Comment on attachment 8833432 [details]
Bug 1336515: Fix assertions in TIPMessageHandler instantiation on non-touchscreen devices;

Approval Request Comment
[Feature/Bug causing the regression]: Win8 touchscreen
[User impact if declined]: Assertions (debug builds only)
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]:  No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Trivial patch, affects debug builds only
[String changes made/needed]: None
Attachment #8833432 - Flags: approval-mozilla-beta?
Attachment #8833432 - Flags: approval-mozilla-aurora?
Comment on attachment 8833432 [details]
Bug 1336515: Fix assertions in TIPMessageHandler instantiation on non-touchscreen devices;

Fix assertions on non-touchscreen devices. Aurora53+.
Attachment #8833432 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8833432 [details]
Bug 1336515: Fix assertions in TIPMessageHandler instantiation on non-touchscreen devices;

avoid assertion in debug builds, beta52+
Attachment #8833432 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.