Closed Bug 1336549 Opened 3 years ago Closed 3 years ago
Resolve libc version conflict between webrender and mozjs
59 bytes, text/x-review-board-request
Right now on the graphics branch, the version of libc in third_party/rust has been upgraded to 0.2.20 (it's 0.2.18 on m-c). The mozjs_sys crate's lockfile explicitly references 0.2.18, so it fails to build on the graphics branch. As a prerequisite of merging the graphics branch to m-c, we need resolve this mismatch. (Note that the fact that we got into this situation in the first place is a cargo-vendor bug, for which I filed bug 1336528.) We can resolve the mismatch in one of two ways: upgrade mozjs_sys from using 0.2.18 to using 0.2.20, or downgrade webrender from using 0.2.20 to using 0.2.18. I'd prefer to do the former, since it's a patchlevel upgrade which in theory should just be bugfixes.
In addition to libc, the pkg-config version also conflicts (mozjs_sys wants 0.3.8, graphics branch currently has 0.3.9). I'll probably just update all the third-party dependencies of mozjs_sys. It looks like that was done previously in bug 1324920.
I'll wait for the try push before putting this up for review. https://treeherder.mozilla.org/#/jobs?repo=try&revision=50569daaf93e61ed24811e3801ac51392182ea4d
Builds and mozjs-crate are looking green.
Comment on attachment 8833512 [details] Bug 1336549 - Update third-party vendored crates required by mozjs_sys. https://reviewboard.mozilla.org/r/109742/#review110784 rubber stamp = me
Attachment #8833512 - Flags: review?(nfitzgerald) → review+
Comment on attachment 8833512 [details] Bug 1336549 - Update third-party vendored crates required by mozjs_sys. https://reviewboard.mozilla.org/r/109742/#review110794 r=me assuming this is the same patch as the other review request. :)
Attachment #8833512 - Flags: review?(giles) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/02caba8c0a07 Update third-party vendored crates required by mozjs_sys. r=fitzgen,rillian
You need to log in before you can comment on or make changes to this bug.