1336553 - Bump OS X and Windows J chunks from 1 to 2

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Shu-yu Guo [:shu]]

In bug 977849 we're trying to land the externally maintained JS conformance suite, test262. This adds ~20k new tests and is causing bustage on OS X J jobs, such as in this try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e24a41b0d7f9c39eae9100d8155b94c485f5678&selectedJob=74174486&filter-searchStr=OS%20X%20J

I've bumped the chunk count for TC and mozharness job since they are in tree. Could someone help me do this for OS X, since it's buildbot?

Comment 1

[Shu-yu Guo [:shu]]

ETA on this? I'd like to land bug 977849 this week.

Comment 2

[Sebastian Pacurar [:spacurar]]

Attachment: bug_1336553.patch

Comment 3

[Sebastian Pacurar [:spacurar]]

Attachment: diff.txt

This is the result of the difference between the old configuration and the new configuration after the patch was placed

Comment 4

[Kim Moir [:kmoir] ET]

:spacurar Your builder diff shows that the two chunks will be enabled on most branches at once. Usually we enable new test chunking on trunk to allow the associated patches for the tests to be uplifted to m-c and ride the trains.  Is that the intention from :shu who requested this patch?

Comment 5

[Shu-yu Guo [:shu]]

(In reply to Kim Moir [:kmoir] from comment #4)
> :spacurar Your builder diff shows that the two chunks will be enabled on
> most branches at once. Usually we enable new test chunking on trunk to allow
> the associated patches for the tests to be uplifted to m-c and ride the
> trains.  Is that the intention from :shu who requested this patch?

My intention was for mozilla-central only, not all branches. The new chunk #, as well as test262, will ride the trains as usual.

Comment 6

[Kim Moir [:kmoir] ET]

Okay, great. Sebastian could you please refactor your patches so this change rides the trains instead of enabling it on all branches at once?

Comment 7

[Kim Moir [:kmoir] ET]

Comment on attachment 8834895 [details] [diff] [review]
bug_1336553.patch

patch needs to ride trains

Comment 8

[Sebastian Pacurar [:spacurar]]

Attachment: bug_1336553_v2.patch

Comment 9

[Sebastian Pacurar [:spacurar]]

Attachment: diff2

new tests diff

Comment 10

[Alin Selagea [:aselagea]]

Comment on attachment 8835482 [details] [diff] [review]
bug_1336553_v2.patch

The patch is in production: https://hg.mozilla.org/build/buildbot-configs/rev/f31308774cb2

Comment 11

[Shu-yu Guo [:shu]]

I mistakenly believed Windows J tasks were in TC. They need to be bumped 1 -> 2 as well. Sorry about that.

Comment 12

[Alin Selagea [:aselagea]]

Splitting this in 2 chunks for OS X resulted in more tests to be scheduled and, unfortunately, our infra doesn't seem to be able to keep up at the moment.

Comment 13

[Sebastian Pacurar [:spacurar]]

Attachment: bug_1336553_v3.patch

Comment 14

[Sebastian Pacurar [:spacurar]]

Attachment: diff_for_windows

This is the diff file for the Windows J tests which are now chunked from 1 to 2

Comment 15

[Alin Selagea [:aselagea]]

Comment on attachment 8835483 [details]
diff2

>--- old_sorted	2017-02-09 04:39:49.661182713 -0800
>+++ new_sorted	2017-02-09 04:48:41.947109464 -0800
>-Rev7 MacOSX Yosemite 10.10.5 ash debug test jsreftest-e10s ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 ash debug test jsreftest-e10s-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 ash debug test jsreftest-e10s-2 ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 ash opt test jsreftest-e10s ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 ash opt test jsreftest-e10s-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 ash opt test jsreftest-e10s-2 ScriptFactory
>
>-Rev7 MacOSX Yosemite 10.10.5 autoland debug test jsreftest-e10s ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 autoland debug test jsreftest ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 autoland debug test jsreftest-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 autoland debug test jsreftest-2 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 autoland debug test jsreftest-e10s-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 autoland debug test jsreftest-e10s-2 ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 autoland opt test jsreftest-e10s ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 autoland opt test jsreftest ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 autoland opt test jsreftest-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 autoland opt test jsreftest-2 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 autoland opt test jsreftest-e10s-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 autoland opt test jsreftest-e10s-2 ScriptFactory
>
>-Rev7 MacOSX Yosemite 10.10.5 elm debug test jsreftest-e10s ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 elm debug test jsreftest ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 elm debug test jsreftest-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 elm debug test jsreftest-2 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 elm debug test jsreftest-e10s-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 elm debug test jsreftest-e10s-2 ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 elm opt test jsreftest-e10s ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 elm opt test jsreftest ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 elm opt test jsreftest-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 elm opt test jsreftest-2 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 elm opt test jsreftest-e10s-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 elm opt test jsreftest-e10s-2 ScriptFactory
>
>-Rev7 MacOSX Yosemite 10.10.5 graphics debug test jsreftest-e10s ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 graphics debug test jsreftest ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 graphics debug test jsreftest-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 graphics debug test jsreftest-2 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 graphics debug test jsreftest-e10s-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 graphics debug test jsreftest-e10s-2 ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 graphics opt test jsreftest-e10s ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 graphics opt test jsreftest ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 graphics opt test jsreftest-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 graphics opt test jsreftest-2 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 graphics opt test jsreftest-e10s-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 graphics opt test jsreftest-e10s-2 ScriptFactory
>
>-Rev7 MacOSX Yosemite 10.10.5 larch debug test jsreftest-e10s ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 larch debug test jsreftest ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 larch debug test jsreftest-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 larch debug test jsreftest-2 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 larch debug test jsreftest-e10s-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 larch debug test jsreftest-e10s-2 ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 larch opt test jsreftest-e10s ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 larch opt test jsreftest ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 larch opt test jsreftest-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 larch opt test jsreftest-2 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 larch opt test jsreftest-e10s-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 larch opt test jsreftest-e10s-2 ScriptFactory
>
>-Rev7 MacOSX Yosemite 10.10.5 mozilla-central debug test jsreftest-e10s ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 mozilla-central debug test jsreftest ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 mozilla-central debug test jsreftest-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 mozilla-central debug test jsreftest-2 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 mozilla-central debug test jsreftest-e10s-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 mozilla-central debug test jsreftest-e10s-2 ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 mozilla-central opt test jsreftest-e10s ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 mozilla-central opt test jsreftest ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 mozilla-central opt test jsreftest-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 mozilla-central opt test jsreftest-2 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 mozilla-central opt test jsreftest-e10s-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 mozilla-central opt test jsreftest-e10s-2 ScriptFactory
>
>-Rev7 MacOSX Yosemite 10.10.5 mozilla-inbound debug test jsreftest-e10s ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 mozilla-inbound debug test jsreftest ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 mozilla-inbound debug test jsreftest-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 mozilla-inbound debug test jsreftest-2 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 mozilla-inbound debug test jsreftest-e10s-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 mozilla-inbound debug test jsreftest-e10s-2 ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 mozilla-inbound opt test jsreftest-e10s ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 mozilla-inbound opt test jsreftest ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 mozilla-inbound opt test jsreftest-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 mozilla-inbound opt test jsreftest-2 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 mozilla-inbound opt test jsreftest-e10s-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 mozilla-inbound opt test jsreftest-e10s-2 ScriptFactory
>
>-Rev7 MacOSX Yosemite 10.10.5 oak debug test jsreftest-e10s ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 oak debug test jsreftest ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 oak debug test jsreftest-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 oak debug test jsreftest-2 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 oak debug test jsreftest-e10s-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 oak debug test jsreftest-e10s-2 ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 oak opt test jsreftest-e10s ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 oak opt test jsreftest ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 oak opt test jsreftest-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 oak opt test jsreftest-2 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 oak opt test jsreftest-e10s-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 oak opt test jsreftest-e10s-2 ScriptFactory
>
>-Rev7 MacOSX Yosemite 10.10.5 try debug test jsreftest-e10s ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 try debug test jsreftest ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 try debug test jsreftest-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 try debug test jsreftest-2 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 try debug test jsreftest-e10s-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 try debug test jsreftest-e10s-2 ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 try opt test jsreftest-e10s ScriptFactory
>-Rev7 MacOSX Yosemite 10.10.5 try opt test jsreftest ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 try opt test jsreftest-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 try opt test jsreftest-2 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 try opt test jsreftest-e10s-1 ScriptFactory
>+Rev7 MacOSX Yosemite 10.10.5 try opt test jsreftest-e10s-2 ScriptFactory

Comment 16

[Shu-yu Guo [:shu]]

(In reply to Alin Selagea [:aselagea][:buildduty] from comment #12)
> Splitting this in 2 chunks for OS X resulted in more tests to be scheduled
> and, unfortunately, our infra doesn't seem to be able to keep up at the
> moment.

How hard would it be to make the J tasks on all platforms only run with js/src is touched, like the SM tasks?

Comment 17

[Kim Moir [:kmoir] ET]

Comment on attachment 8836069 [details] [diff] [review]
bug_1336553_v3.patch

Not sure why you need
and slave_platform.startswith('win7_') is False: 

part but the diff looks good

Comment 18

[Phil Ringnalda (:philor)]

js/src or the reftest harness or other things I'm not thinking of are touched, like test packaging so the whole build system.

Comment 19

[Sebastian Pacurar [:spacurar]]

(In reply to Kim Moir [:kmoir] from comment #17)
> Comment on attachment 8836069 [details] [diff] [review]
> bug_1336553_v3.patch
> 
> Not sure why you need
> and slave_platform.startswith('win7_') is False: 
> 
> part but the diff looks good

I used the startswith() method so I can avoid writing down all the win32 windows 7 slave_platforms. So to avoid a long list like this "if slave_platform  not in ['yosemite_r7', 'win8_64', 'win7_ix', 'win7_vm', 'win7_vm_gfx']" I used the startswith method for windows 7 slave_platforms.