Sent tab notifications should be dismissed after tab activation

NEW
Unassigned

Status

()

Core
Widget: Cocoa
P5
normal
2 years ago
a year ago

People

(Reporter: modestdev, Unassigned)

Tracking

54 Branch
x86_64
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: tpi:+)

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170125094131

Steps to reproduce:

Send tab from Firefox Mobile to Firefox Desktop on Mac


Actual results:

- Sent tab appears on Firefox Desktop.
- Notification is displayed in Mac sidebar.
- After click on new tab notification stays in sidebar and can be cleared only manually.


Expected results:

After click on new tab notification should be cleared automatically.
(Reporter)

Updated

2 years ago
OS: Unspecified → Mac OS X
Hardware: Unspecified → x86_64

Comment 1

2 years ago
Can you please attach a print screen or a screen recorder to have a better understanding? I don't know about what notification are you referring. Thanks
Flags: needinfo?(modestdev)
(Reporter)

Comment 2

2 years ago
Created attachment 8835330 [details]
Screen Shot 2017-02-09 at 10.24.04.png
(Reporter)

Updated

2 years ago
Flags: needinfo?(modestdev)

Comment 3

2 years ago
Tested on Mac OS X 10.12 with FF Nightly 54.0a1(2017-02-08) and I can reproduce this behaviour. I don't know if this is intended or not. I will mark this as new and see what developers have to say about the behaviour. Also in my opinion this sounds like an enhancement. Thanks for your screen shot.
Status: UNCONFIRMED → NEW
Component: Untriaged → Widget: Cocoa
Ever confirmed: true
Product: Firefox → Core
Version: 51 Branch → 54 Branch
Hey Stephen, this seems like it might be misfiled, not sure though. is this sidebar integration down in widget?
Flags: needinfo?(spohl.mozilla.bugs)
(In reply to Jim Mathies [:jimm] from comment #4)
> Hey Stephen, this seems like it might be misfiled, not sure though. is this
> sidebar integration down in widget?

I don't know off-hand, but it does seem like this integration would be in widget:cocoa. Markus, do you happen to know this?
Flags: needinfo?(spohl.mozilla.bugs) → needinfo?(mstange)
It's probably in widget/cocoa/OSXNotificationCenter.mm.

Kit, would you like to take a look at this?
Flags: needinfo?(mstange) → needinfo?(kit)
This seems consistent with how web notifications work in Firefox and Safari. Clicking on a "banner" style alert keeps it in the notification center until the app is closed, and it's possible to click on the alert in the notification center to trigger the same action more than once.

Given that it's consistent with web notifications, I'm inclined to say this is working is intended, and being able to bring up the same sent tab multiple times is a feature. I'd definitely be open to changing it if you feel auto-clearing is a better experience, though.
Flags: needinfo?(kit)

Updated

a year ago
Priority: -- → P5
Whiteboard: tpi:+
You need to log in before you can comment on or make changes to this bug.