javascript strict warnings in findUtils.js

VERIFIED FIXED

Status

SeaMonkey
UI Design
VERIFIED FIXED
16 years ago
10 years ago

People

(Reporter: Henrik Gemal, Assigned: Biesinger)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

884 bytes, patch
Biesinger
: review+
Alec Flett
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

16 years ago
Warning: function findAgainInPage does not always return a value
Source File: chrome://communicator/content/findUtils.js
Line: 106
Source Code:
}

v 20020326
(Reporter)

Updated

16 years ago
Summary: javascript strict warnings in utilityOverlay.js → javascript strict warnings in findUtils.js

Comment 1

16 years ago
-> XPApps: GUI Features for find
Assignee: sgehani → blaker
Component: Search → XP Apps: GUI Features
QA Contact: claudius → paw

Comment 2

16 years ago
qa for FIND --> pmac@netscape.com
QA Contact: paw → pmac

Comment 3

16 years ago
Created attachment 80306 [details] [diff] [review]
proposed patch

this gets rid of the warning

Comment 4

16 years ago
Created attachment 80309 [details] [diff] [review]
patch v2

better patch, according to comments by biesi

Updated

16 years ago
Attachment #80306 - Attachment is obsolete: true
Comment on attachment 80309 [details] [diff] [review]
patch v2

r=biesi
Attachment #80309 - Flags: review+

Comment 6

16 years ago
Comment on attachment 80309 [details] [diff] [review]
patch v2

sr=alecf
Attachment #80309 - Flags: superreview+
taking bug for checkin
Assignee: blaker → cbiesinger
checked in
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
QA Contact: pmac → sairuh
don't see this error in the js console when using the find in page feature.
tested with 2003.01.08.08 comm bits on linux rh8.
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite

Updated

10 years ago
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.