1336756 - Error console in Thunderbird Beta shows promo/suggests to use Firefox Developer Edition

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The error console in Thunderbird Beta suggests to use Firefox Developer Edition for thing you are currently attempting to do.

Cause: pref("devtools.devedition.promo.enabled", true);

https://hg.mozilla.org/mozilla-central/annotate/ee975d32deb9eaa5641f45428cd6a4b5b555a8f5/devtools/client/preferences/devtools.js#l10

Adding
>// Don't show the promo for the FirefoxDeveloper Edition
>pref("devtools.devedition.promo.enabled", false);
>pref("devtools.devedition.promo.shown", true);
to all-thunderbird.js fixes the issue here, but this file is in omni.ja/defaults/pref like devtools.js with the opposite value.

Do the values from all-thunderbird.js always take precedence?

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Preferences loading code: https://dxr.mozilla.org/comm-central/source/mozilla/modules/libpref/Preferences.cpp#1229

Comment 2

[Jorg K (CEST = GMT+2)]

(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #0)
> Do the values from all-thunderbird.js always take precedence?
I think that's the idea without having looked at it.

Comment 3

[Wayne Mery (:wsmwk)]

I'm not finding the pref in a current bbeta