1336791 - "./mach run" fails with readelf from ELF ToolChain

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jan Beich]

Attachment: readelf -d libxul.so output (as diff)

FreeBSD since 11.0 replaced some tools from GNU binutils with ELF ToolChain equivalents. However, their output isn't always identical to GNU which breaks logic dependentlibs.list logic.

$ ./mach build
$ ./mach run
 0:00.12 objdir/dist/bin/firefox -no-remote -profile objdir/tmp/scratch_user
XPCOMGlueLoad error for file objdir/dist/bin/libxul.so:
Shared object "liblgpllibs.so" not found, required by "libxul.so"
Couldn't load XPCOM.

$ cat objdir/dist/bin/dependentlibs.list
libxul.so

Comment 1

[Jan Beich]

Attachment: Bug 1336791 - Allow readelf to print types without parentheses.

Review commit: https://reviewboard.mozilla.org/r/109916/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109916/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8833734 [details]
Bug 1336791 - Allow readelf to print types without parentheses.

https://reviewboard.mozilla.org/r/109916/#review111414

::: toolkit/library/dependentlibs.py:58
(Diff revision 1)
>          # Each line has the following format:
>          #  tag (TYPE)          value

Can you add a note here about the variant of output you're seeing?

Comment 3

[Jan Beich]

Comment on attachment 8833734 [details]
Bug 1336791 - Allow readelf to print types without parentheses.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/109916/diff/1-2/

Comment 4

[Ed Maste [:emaste]]

ELF Tool Chain ticket for this issue: https://sourceforge.net/p/elftoolchain/tickets/544/

Example output:
% readelf -d /bin/ls

Dynamic section at offset 0x7028 contains 23 entries:
  Tag                Type                  Name/Value
 0x0000000000000001 NEEDED               Shared library: [libutil.so.9]
 0x0000000000000001 NEEDED               Shared library: [libncurses.so.8]
 0x0000000000000001 NEEDED               Shared library: [libc.so.7]
 0x000000000000000c INIT                 0x4018c8
 0x000000000000000d FINI                 0x405dd8
...

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8833734 [details]
Bug 1336791 - Allow readelf to print types without parentheses.

https://reviewboard.mozilla.org/r/109916/#review111832

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/478a60d64023
Allow readelf to print types without parentheses. r=glandium

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/478a60d64023

Comment 8

[Jan Beich]

Comment on attachment 8833734 [details]
Bug 1336791 - Allow readelf to print types without parentheses.

I'd like this backported to Firefox 53.0 and 52.1.0 ESR. The merge date is close, so one of approval* flags maybe redundant.

Approval Request Comment
[ESR consideration]: Easier testing on FreeBSD without having to embed RPATH or pass LD_LIBRARY_PATH
[Feature/Bug causing the regression]: bug 763893 feature
[User impact if declined]: Broken startup on FreeBSD 11.0 or later unless GNU readelf (from binutils) is installed and precede in PATH
[Is this code covered by automated tests?]: No, tests always pass LD_LIBRARY_PATH from environment
[Has the fix been verified in Nightly?]: Yes, by myself for both GNU and BSD readelf including backport to Firefox 52.
[Needs manual test from QE? If yes, steps to reproduce]: Probably not
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Can only break startup on Linux similar to comment 0 which would be quickly noticed by users
[String changes made/needed]: None

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8833734 [details]
Bug 1336791 - Allow readelf to print types without parentheses.

Happy to take this for aurora so builds don't break for FreeBSD.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/809356dad7f4

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 8833734 [details]
Bug 1336791 - Allow readelf to print types without parentheses.

handle bsd readelf's output, for esr52.1.0

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/53b327c4fea1