add i686-unknown-openbsd to known rust targets

RESOLVED FIXED in Firefox 53

Status

RESOLVED FIXED
2 years ago
6 months ago

People

(Reporter: gaston, Assigned: gaston)

Tracking

unspecified
mozilla54
x86
OpenBSD

Firefox Tracking Flags

(firefox52 unaffected, firefox53 fixed, firefox54 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Right now configure fails on OpenBSD/i386:
 0:38.35 ERROR: Don't know how to translate i386-unknown-openbsd6.0 for rustc

cf http://buildbot.rhaalovely.net/builders/mozilla-central-i386/builds/807/steps/configure/logs/stdio

Pretty easy to fix, tentative patch in a few.
(Assignee)

Comment 1

2 years ago
Created attachment 8833795 [details] [diff] [review]
bug-1336825

With this patch, configure goes past this step:

DEBUG: rustc: Trying rustc
INFO: /usr/local/bin/rustc
INFO: checking for cargo...
DEBUG: cargo: Trying cargo
INFO: /usr/local/bin/cargo
INFO: checking rustc version...
DEBUG: Executing: `/usr/local/bin/rustc --version --verbose`
INFO: 1.14.0
INFO: checking cargo support for --frozen...
INFO: yes
DEBUG: Creating `/tmp/conftestfATseb.rs` with content:
DEBUG: | pub extern fn hello() { println!("Hello world"); }
DEBUG: Executing: `/usr/local/bin/rustc --crate-type staticlib --target=i686-unknown-openbsd -o /tmp/conftestLs7G2X.rlib /tmp/conftestfATseb.rs`
DEBUG: Creating `/tmp/conftestaWOnBY.rs` with content:
DEBUG: | pub extern fn hello() { println!("Hello world"); }
DEBUG: Executing: `/usr/local/bin/rustc --crate-type staticlib --target=i686-unknown-openbsd -o /tmp/conftestR6C38t.rlib /tmp/conftestaWOnBY.rs`


cf http://buildbot.rhaalovely.net/builders/mozilla-central-i386/builds/808
Assignee: nobody → landry
Attachment #8833795 - Flags: review?(mh+mozilla)
(Assignee)

Updated

2 years ago
status-firefox52: --- → ?
status-firefox53: --- → affected
status-firefox54: --- → affected
Comment on attachment 8833795 [details] [diff] [review]
bug-1336825

Review of attachment 8833795 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing review!
Attachment #8833795 - Flags: review?(mh+mozilla) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 3

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7111d1d64cc2
Add i686-unknown-openbsd to known rust targets. r=froydnj
Keywords: checkin-needed
(Assignee)

Comment 4

2 years ago
Comment on attachment 8833795 [details] [diff] [review]
bug-1336825

Approval Request Comment
[Feature/Bug causing the regression]: 1284816
[User impact if declined]: Failure to build on OpenBSD/i386
[Is the change risky?]: NPOTB
Attachment #8833795 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

2 years ago
status-firefox52: ? → unaffected

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7111d1d64cc2
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Comment on attachment 8833795 [details] [diff] [review]
bug-1336825

Fix a build issue on OpenBSD/i386. Aurora53+.
Attachment #8833795 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 7

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/70f5d6066954
status-firefox53: affected → fixed

Updated

6 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.