Closed
Bug 1336855
Opened 7 years ago
Closed 7 years ago
Use shared_ptr more in ssl_gtests
Categories
(NSS :: Test, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.30
People
(Reporter: mt, Assigned: mt)
References
Details
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
Well, as it turned out, we have to use shared_ptr. Worse, the packet filters need to use weak_ptr in order to ensure that we don't end up with circular references and leaks. Only the model sockets we use can use unique_ptr. https://nss-review.dev.mozaws.net/D194
Summary: Use unique_ptr for client_ and server_ in gtests → Use shared_ptr for client_ and server_ in gtests
|
|
Assignee | |
Comment 2•7 years ago
|
||
Added https://nss-review.dev.mozaws.net/D195 and https://nss-review.dev.mozaws.net/D196 to the stack.
Summary: Use shared_ptr for client_ and server_ in gtests → Use shared_ptr more in ssl_gtests
|
|
Assignee | |
Comment 3•7 years ago
|
||
Also https://nss-review.dev.mozaws.net/D197
|
|
Assignee | |
Comment 4•7 years ago
|
||
remote: https://hg.mozilla.org/projects/nss/rev/bd50c150c6d980791e161bd1ba12474dc10291a4 remote: https://hg.mozilla.org/projects/nss/rev/e7b4674911a6192b6bda6339fb4686e404f40e0a remote: https://hg.mozilla.org/projects/nss/rev/b931aa1b606b315cc7d2bc3768e984eae0d1afbb remote: https://hg.mozilla.org/projects/nss/rev/fa82fed6415c6be9821ec16a919f80d0451bef8e remote: https://hg.mozilla.org/projects/nss/rev/681f3448599f4efdbf499a14565426dfca539d66 remote: https://hg.mozilla.org/projects/nss/rev/e3bca65235d5bf2f3c07856d75556e6aeb80ecd2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.30
You need to log in
before you can comment on or make changes to this bug.
Description
•