133687 - [INSUFFICIENT BROWSER-SNIFFING] Javascript Together with an Client MAP does not work

Status: VERIFIED FIXED

(Tech Evangelism Graveyard :: German, defect, P2)

Description

[Heinz Mueller]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:0.9.9+) Gecko/20020325
BuildID:    all

On the Mainpage of this site is a graph of a church.
This should show sticky notes.

It does work under 4.61 and does not work under mozilla!

Reproducible: Always
Steps to Reproduce:
1.Call the url
2.put the cursor on the Church Tower of the graphic
3.

Actual Results:  No sticky notes, that are displayed under Netscape 4.6.1

Expected Results:  Show the sticky notes

Source - code available, if desired.

Comment 1

[Mike Kaply [:mkaply]]

Not OS/2 specific and I don't see layers on this page

Comment 2

[Phil Schwartau]

The site uses this <DIV> to contain the sticky notes:

<div id="overDiv" style="position:absolute; visibility:hide;z-index:1;"></div>

The external JS file used to fill it is

     view-source:http://www.ekg-oeschingen.de/overlib.js

which contains insufficient browser-sniffing:


// Decide browser version
var ns4 = (document.layers)? true:false
var ie4 = (document.all)? true:false

// Microsoft Stupidity Check(tm).
if (ie4) {
if (navigator.userAgent.indexOf('MSIE 5')>0) {
var ie5 = true;
} else {
var ie5 = false;
}
} else {
var ie5 = false;
}

// Capture events and set over to correct DOM position.
if ( (ns4) || (ie4) ) {
if (ns4) over = document.overDiv
if (ie4) over = overDiv.style
document.onmousemove = mouseMove
if (ns4) document.captureEvents(Event.MOUSEMOVE)
}



The key dynamic functions are these:



///////////////////////////////////////////////////////////////////////////////
// LAYER FUNCTIONS
///////////////////////////////////////////////////////////////////////////////

// Writes to a layer
function layerWrite(txt)
{
  if (ns4)
  {
    var lyr = document.overDiv.document <--- HOW THE <DIV> IS ACCESSED IN NN4.7
    lyr.write(txt)
    lyr.close()
  }
  else if (ie4) 
    document.all["overDiv"].innerHTML = txt

  if (o3_tracker) { trk(); }
}


// Make an object visible
function showObject(obj)
{
  if (ns4) obj.visibility = "show"
  else if (ie4) obj.visibility = "visible"
}


// Hides an object
function hideObject(obj)
{
  if (ns4) obj.visibility = "hide"
  else if (ie4) obj.visibility = "hidden"

  self.status = "";
}



Bottom line: |ns4| and |ie4| both evaluate to false in Mozilla,
since Mozilla does not support document.layers or document.all.
Therefore, none of the "layer" functions are going to do anything...

Reassigning to Tech Evangelism component -

Comment 3

[Heinz Mueller]

Well the lack of these features will break a löot of code outside.
What's the alternative ?

Comment 4

[Phil Schwartau]

Here are some useful references:

http://devedge.netscape.com/evangelism/docs/
http://devedge.netscape.com/evangelism/docs/articles/updating-dhtml-web-pages/
http://www.mozilla.org/docs/web-developer/upgrade_2.html

Comment 5

[Mathieu Pillard [:mat]]

they should use the latest version available from
http://www.bosrup.com/web/overlib, which supports mozilla.

Comment 6

[Frederic Bezies]

Contact : [e-mail]

Comment 7

[Michael Schumacher]

http://www.ekg-oeschingen.de/overlib.js

[...]
var ns6 = (document.getElementById)? true:false;
[...]

Sticky notes are shown, so this bug is apparently fixed.

Comment 8

[Mathieu Pillard [:mat]]

yup. fixed.

Comment 9

[Brant Gurganus]

v

Comment 10

[Bob Clary [:bc] (inactive)]

tech evang june 2003 reorg