1336873 - Force to crash if we get the the unexpected new output stream when receive MF_E_TRANSFORM_STREAM_CHANGE

Status: RESOLVED WORKSFORME

(Core :: Audio/Video: Playback, defect)

Description

[Alastor Wu [:alwu]]

Fork from bug1281835 comment18. 
Force to crash can make us know whether that situation is the reason of the crash in bug1281835.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1336873 - Force to crash if we get the the unexpected new output stream when receive MF_E_TRANSFORM_STREAM_CHANGE.

Force to crash can make us know whether that situation is the reason of the crash in bug1281835.

Review commit: https://reviewboard.mozilla.org/r/109972/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109972/

Comment 2

[James Cheng[:JamesCheng]]

Comment on attachment 8833843 [details]
Bug 1336873 - Force to crash if we get the the unexpected new output stream when receive MF_E_TRANSFORM_STREAM_CHANGE.

https://reviewboard.mozilla.org/r/109972/#review110946

::: dom/media/platforms/wmf/MFTDecoder.cpp:225
(Diff revision 1)
> +    if (status == MFT_PROCESS_OUTPUT_STATUS_NEW_STREAMS) {
> +      DWORD inputCount, outputCount;
> +      mDecoder->GetStreamCount(&inputCount, &outputCount);
> +      if (inputCount != outputCount) {
> +        MOZ_CRASH("Got unexpected new output stream.");
> +      }

Does in/output count is a useful information for debugging?

If so, I suggest you can print it down just like [1]
did.


[1]
http://searchfox.org/mozilla-central/source/dom/media/MediaShutdownManager.cpp#79-83

Comment 3

[Alastor Wu [:alwu]]

After more survey, I found that our MFT has a fixed number of streams. 
So this checking is meaningless.