Closed
Bug 1336879
Opened 7 years ago
Closed 7 years ago
Use Vista+ API directly for nsWin32Locale
Categories
(Core :: Internationalization, defect)
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file, 1 obsolete file)
|
7.85 KB,
patch
|
emk
:
review+
|
Details | Diff | Splinter Review |
Now, we don't support XP, so it is unnecessary to use GetProcAddress to use Vista+ API into Win32Locale.
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
Comment on attachment 8833854 [details] [diff] [review] Use Vista+ API directly for nsWin32Locale LocaleNameToLCID and LCIDToLocaleName are available from Vista+, so we don't need LoadLibrary to use this since we don't support XP.
Attachment #8833854 -
Flags: review?(VYV03354)
|
||
Updated•7 years ago
|
Attachment #8833854 -
Flags: review?(VYV03354) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
sorry, length contains null. I will update fix.
|
|
Assignee | |
Comment 4•7 years ago
|
||
Sorry for review again. Previous patch has incorrectly length calculation.
Attachment #8833854 -
Attachment is obsolete: true
Attachment #8833922 -
Flags: review?(VYV03354)
|
|
||
Comment 5•7 years ago
|
||
Comment on attachment 8833922 [details] [diff] [review] Use Vista+ API directly for nsWin32Locale v2 Review of attachment 8833922 [details] [diff] [review]: ----------------------------------------------------------------- https://msdn.microsoft.com/ja-jp/library/windows/desktop/dd318698(v=vs.85).aspx > Returns the count of characters, including the terminating null character, Oh, sorry, I didn't notice the bug.
Attachment #8833922 -
Flags: review?(VYV03354) → review+
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/mozilla-inbound/rev/51546f9d44b8 Use Vista+ API directly for nsWin32Locale. r=emk
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/51546f9d44b8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•