Closed
Bug 1336950
Opened 7 years ago
Closed 7 years ago
jit-test/tests/auto-regress/bug1334573.js fails if Intl is disabled
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: jandem, Assigned: anba)
References
Details
Attachments
(1 file)
|
720 bytes,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
I usually use --without-intl-api shell builds.
This test expects an error, but the code is inside |if (this.Intl) {}| so if we don't have Intl enabled we don't throw anything.
|
Assignee | |
Comment 1•7 years ago
|
||
Now that bug 1215247 has landed we're one step closer to remove the option to build without Intl. :-)
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8835474 -
Flags: review?(jdemooij)
|
Reporter | |
Comment 2•7 years ago
|
||
Comment on attachment 8835474 [details] [diff] [review] bug1336950.patch Review of attachment 8835474 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8835474 -
Flags: review?(jdemooij) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7cf0a164b082 Add fallback code when Intl is not present to jit-test/tests/auto-regress/bug1334573.js. r=jandem
Keywords: checkin-needed
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7cf0a164b082
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•