Closed
Bug 1336958
Opened 8 years ago
Closed 8 years ago
Call delete on HTML::Tree objects to avoid leaking memory
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dylan, Assigned: dylan)
References
Details
Attachments
(1 file)
|
1.23 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
Reading the documentation of HTML::Tree https://metacpan.org/pod/HTML::Tree#SYNOPSIS
Compare that with what we actually do in these two extensions:
- https://github.com/mozilla-bteam/bmo/blob/master/extensions/SecureMail/Extension.pm#L645
- https://github.com/mozilla-bteam/bmo/blob/master/extensions/Profanivore/Extension.pm#L156
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8833963 -
Flags: review?(dkl)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8833963 [details] [diff] [review]
1336958_1.patch
Review of attachment 8833963 [details] [diff] [review]:
-----------------------------------------------------------------
r=dkl
Attachment #8833963 -
Flags: review?(dkl) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
To git@github.com:mozilla-bteam/bmo.git
dc47938..92ca9f6 master -> master
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•8 years ago
|
||
This is now live.
dkl
|
||
Updated•6 years ago
|
Component: Extensions: SecureMail → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•