1336972 - TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_addEngine_callback.js and many more

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/unit/test_PlacesSearchAutocompleteProvider.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_addEngine_callback.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_addEngine_callback.js | simple_callback_test - [simple_callback_test : 43] "Test search engine" != "Test search engine"
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_defaultEngine.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_defaultEngine.js | test_defaultEngine - [test_defaultEngine : 38] [object XPCWrappedNative_NoHelper] == null
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_selectedEngine.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_selectedEngine.js | test_defaultEngine - [test_defaultEngine : 12] "Test search engine" == "Bing"
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_currentEngine_fallback.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_currentEngine_fallback.js | run_test - [run_test : 5] false == true
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_geodefaults.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_geodefaults.js | no_request_if_prefed_off - TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_addEngineWithDetails.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_searchReset.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_engineUpdate.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/search/tests/xpcshell/test_engineUpdate.js | test_engineUpdate - [test_engineUpdate : 38] Order not cleared by update - "undefined" == 1
TEST-UNEXPECTED-TIMEOUT | toolkit/components/search/tests/xpcshell/test_nocache.js | Test timed out

First seen Sun Feb 5, 2017, 11:10:55
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=cedd5f2f7fa64aeb7eae002f4b1ee7503c938d35

I think it's not related to bug 1336789 although that landed in the same range.

M-C first bad: 3e555770a90a41e04bbb4ac41b65fa2f1d
M-C last good: f8d696a34c172ce8e118d5af0b0e7b7f4b

Range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f8d696a34c172ce8e118d5af0b0e7b7f4b&tochange=3e555770a90a41e04bbb4ac41b65fa2f1d

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1336972.log - Logfile complaining about "search engine not found".

This is what I see on the debug console in a local build.

Looks like this comes from bug 1328713.

Michael and Florian, could you please take a look.

Comment 2

[Mike Kaply [:mkaply]]

It looks like when i put in the new python for generating JSON, I forgot to add an if check. I'll fix today.

Comment 3

[Jorg K (CEST = GMT+2)]

Thanks. Our C-C tree looks frustratingly bad these days, so any test failures we can get fixed will make it less sad.

Comment 4

[Jorg K (CEST = GMT+2)]

(In reply to Mike Kaply [:mkaply] from comment #2)
> It looks like when i put in the new python for generating JSON, I forgot to
> add an if check. I'll fix today.
That takes care of the log messages, too? (attachment 8833973 [details])

Comment 5

[Mike Kaply [:mkaply]]

> That takes care of the log messages, too? (attachment 8833973 [details])

Yep, it's all the same thing. Sorry about that. I am very conscious of Thunderbird in this work, and I should have caught this.

Comment 6

[Mike Kaply [:mkaply]]

Attachment: Fix

Adding region overrides to the thunderbird version fixes this.

Comment 7

[Florian Quèze [:florian]]

Comment on attachment 8834029 [details] [diff] [review]
Fix

Review of attachment 8834029 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me.

Comment 8

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/1eae202f7efacdce5ccff2bac1fb0b79dce30425

Thank you!

Comment 9

[Jorg K (CEST = GMT+2)]

Thanks again, Mike. These test failures are gone and there are some green dots again in our tree.

Comment 10

[Mike Kaply [:mkaply]]

You should put this fix in Aurora to as I will be uplifting the patch to there.

Comment 11

[Jorg K (CEST = GMT+2)]

Aurora (TB 53):
https://hg.mozilla.org/releases/comm-aurora/rev/7a02bddb54efc3c7ad4da4534098c3fe1e24d885