The default bug view has changed. See this FAQ.

Firefox Menu not using Sync account image but Preferences shows specific account image

RESOLVED FIXED in Firefox 52

Status

()

Firefox
Sync
P1
normal
RESOLVED FIXED
2 months ago
8 days ago

People

(Reporter: jaws, Assigned: eoger)

Tracking

52 Branch
Firefox 54
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox52 verified, firefox53 verified, firefox54 verified, firefox55 unaffected, firefox-esr52 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

Created attachment 8834028 [details]
sync-missing-account-image-menupanel.png

See attached image.

I have an account image associated with my account, and this shows in about:preferences, but on the Firefox menu it shows the generic image.

Seen on 54.0a1 (2017-02-06) (64-bit) on Windows 10 Nightly.
Edouard or Mark, could this be fallout from bug 1335538?
Flags: needinfo?(markh)
Flags: needinfo?(eoger)
(Assignee)

Comment 2

2 months ago
Same problem here, it's probably because of this patch. I'm on this.
Assignee: nobody → eoger
Status: NEW → ASSIGNED
Flags: needinfo?(markh)
Flags: needinfo?(eoger)
Comment hidden (mozreview-request)
(Reporter)

Comment 4

2 months ago
mozreview-review
Comment on attachment 8834039 [details]
Bug 1337026 - Cache the FxA profile in the UI.

https://reviewboard.mozilla.org/r/110142/#review111154

::: browser/base/content/browser-fxaccounts.js:160
(Diff revision 1)
>      this.updateUI();
>    },
>  
>    // Note that updateUI() returns a Promise that's only used by tests.
>    updateUI() {
> +    debugger

this should be removed. it will probably fail eslint also.
Comment hidden (mozreview-request)
(Assignee)

Comment 6

2 months ago
Yup sorry it was not meant for review yet, just switching computers :)
(Assignee)

Updated

2 months ago
Blocks: 1335538

Updated

2 months ago
Priority: -- → P1

Comment 7

2 months ago
mozreview-review
Comment on attachment 8834039 [details]
Bug 1337026 - Cache the FxA profile in the UI.

https://reviewboard.mozilla.org/r/110142/#review111312

Thanks Edouard - once this lands, please request uplift of this and bug 1335538
Attachment #8834039 - Flags: review?(markh) → review+

Comment 8

2 months ago
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fad13bbe02de
Cache the FxA profile in the UI. r=markh

Comment 9

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fad13bbe02de
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment on attachment 8834039 [details]
Bug 1337026 - Cache the FxA profile in the UI.

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: We should work hard to get this into 52
User impact if declined: Increased volume to profile.accounts.firefix.com
Fix Landed on Version: 54
Risk to taking this patch (and alternatives if risky): Fairly low risk, limited to the Sync UI, and even then, limited to the user's profile image not being shown.
String or UUID changes made by this patch:  None

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Approval Request Comment
[Feature/Bug causing the regression]: 51
[User impact if declined]: As above
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Yes, as described in the bug.
[List of other uplifts needed for the feature/fix]: Bug 1335538
[Is the change risky?]: Low
[Why is the change risky/not risky?]: Fairly low risk, limited to the Sync UI, and even then, limited to the user's profile image not being shown.
[String changes made/needed]: None
Attachment #8834039 - Flags: approval-mozilla-esr45?
Attachment #8834039 - Flags: approval-mozilla-beta?
Attachment #8834039 - Flags: approval-mozilla-aurora?

Updated

a month ago
status-firefox52: --- → affected
status-firefox53: --- → affected
Hi Brindusa, 
Could you help find someone to verify if this issue was fixed as expected on a latest Nightly build? Thanks!
Flags: needinfo?(brindusa.tot)

Updated

a month ago
status-firefox-esr45: --- → affected
Comment on attachment 8834039 [details]
Bug 1337026 - Cache the FxA profile in the UI.

For ESR, it doesn't match the esr criteria (only sec-high & sec-critical issues). ESR45-.
Attachment #8834039 - Flags: approval-mozilla-esr45? → approval-mozilla-esr45-
Roxana, could you please verify this bug.
Flags: needinfo?(brindusa.tot) → needinfo?(roxana.leitan)
Note Kanchan has been doing QA for this in bug 1335538 - this is a followup of that.
Comment on attachment 8834039 [details]
Bug 1337026 - Cache the FxA profile in the UI.

oops - see comment 10 - I accidentally requested esr45 instead of esr52.
Attachment #8834039 - Flags: approval-mozilla-esr52?
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170214030231

I tested this issue on Windows 10 x64, Ubuntu 16.04 and Mac OS X 10.11 on Nightly 54.0a1 (2017-02-06)(Build ID:20170206030211) and latest Nightly 54.0a1 (2017-02-14) and could not reproduce it.

Can you please check with your account if the issue is still reproducible on the latest Nightly?
Flags: needinfo?(roxana.leitan) → needinfo?(jaws)
I can confirm that this is now fixed in the latest Nightly.
Status: RESOLVED → VERIFIED
status-firefox54: fixed → verified
Flags: needinfo?(jaws)
Comment on attachment 8834039 [details]
Bug 1337026 - Cache the FxA profile in the UI.

Fix a sync UI issue and was verified in nightly. Aurora53+.
Attachment #8834039 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8834039 [details]
Bug 1337026 - Cache the FxA profile in the UI.

This isn't esr-specific, and until the 52 release changes in beta are synced to esr52.
Attachment #8834039 - Flags: approval-mozilla-esr52?
Attachment #8834039 - Flags: approval-mozilla-esr45-
Comment on attachment 8834039 [details]
Bug 1337026 - Cache the FxA profile in the UI.

FxA UI fix, follow-up for 1335538, beta52+
Attachment #8834039 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
status-firefox-esr45: affected → ---
aurora needs rebase:

grafting 396859:fad13bbe02de "Bug 1337026 - Cache the FxA profile in the UI. r=markh"
merging browser/base/content/browser-fxaccounts.js
merging browser/base/content/test/general/browser_fxaccounts.js
warning: conflicts while merging browser/base/content/browser-fxaccounts.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/base/content/test/general/browser_fxaccounts.js! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')
Flags: needinfo?(eoger)
(Assignee)

Comment 22

a month ago
Created attachment 8838081 [details] [diff] [review]
bug-1337026-aurora.patch

Rebased for Aurora, thanks.
Flags: needinfo?(eoger)

Comment 23

a month ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/c589ef7d5db5
status-firefox53: affected → fixed
Flags: in-testsuite+

Comment 24

a month ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/ce5e991a8c21
status-firefox52: affected → fixed

Comment 25

a month ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-esr52/rev/ce5e991a8c21
status-firefox-esr52: --- → fixed

Comment 26

27 days ago
QA Verification: This is to confirm that this issue is fixed on Aurora 53, Beta 52 and ESR 52.
status-firefox52: fixed → verified
status-firefox53: fixed → verified
status-firefox-esr52: fixed → verified

Comment 27

9 days ago
This bug is reproducible in the today's nightly. I performed mozregression and it looks like the following bug has the  changes which introduced the regression:
https://bugzilla.mozilla.org/show_bug.cgi?id=1346987
Status: VERIFIED → REOPENED
status-firefox55: --- → affected
Resolution: FIXED → ---

Comment 28

9 days ago
I don't see account image either in about:preferences or in Firefox menu.

Account image only appears under https://accounts.firefox.com/settings?

Comment 29

8 days ago
Not reproducible in today's nightly.
Status: REOPENED → RESOLVED
Last Resolved: 2 months ago8 days ago
status-firefox55: affected → unaffected
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.