Closed Bug 133705 Opened 23 years ago Closed 23 years ago

Bugs in the Xft library found using the anti-c lint engine.

Categories

(Core :: Layout, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: cyent, Assigned: blizzard)

Details

This is a list of bugs found by antic (http://artho.com/jlint/) The vast majority of false positives have been removed leaving only definite bugs and highly suspicious cases. ====================================================================== This is probably a real bug. As v.u.b will get overwritten. mozilla/other-licenses/Xft/fontconfig/src/fccfg.c:723:13: Possible miss of BREAK before CASE/DEFAULT case FcTypeString: switch (e->op) { case FcOpEqual: case FcOpContains: v.type = FcTypeBool; v.u.b = FcStrCmpIgnoreCase (vl.u.s, vr.u.s) == 0; break; case FcOpNotEqual: v.type = FcTypeBool; v.u.b = FcStrCmpIgnoreCase (vl.u.s, vr.u.s) != 0; break; case FcOpPlus: v.type = FcTypeString; v.u.s = FcStrPlus (vl.u.s, vr.u.s); if (!v.u.s) v.type = FcTypeVoid; break; default: v.type = FcTypeVoid; break; } case FcTypeMatrix: ====================================================================== Again probably a real bug... mozilla/other-licenses/Xft/fontconfig/src/fcdbg.c:137:5: Possible miss of BREAK before CASE/DEFAULT case FcOpMatrix: printf ("[%g %g %g %g]", expr->u.mval->xx, expr->u.mval->xy, expr->u.mval->yx, expr->u.mval->yy); case FcOpBool: printf ("%s", expr->u.bval ? "true" : "false"); break; ====================================================================== And again... mozilla/other-licenses/Xft/fontconfig/src/fcdbg.c:140:5: Possible miss of BREAK before CASE/DEFAULT case FcOpNil: printf ("nil\n"); case FcOpField: printf ("%s", expr->u.field); break; ======================================================================
Just happen to land here looking for current Xft status. Without more context, it's hard to tell if these are bugs, but it looks like the fallthroughs were certainly intentional; I'm not sure if Equals and Contains should both do the same thing, in the first case. Anyway, I'm adding keithp and blizzard to the CC list, since they're the guys (I know of) working on the Xft stuff. (hope that's OK with them).
over to a developer (I'm not)
Assignee: asa → blizzard
Status: UNCONFIRMED → NEW
Component: Browser-General → Layout
Ever confirmed: true
All of these are real bugs. I've fixed them in the XFree86 CVS and my nearly released fontconfig package available at http://keithp.com/fonts I'd change this to 'FIXED', but the Mozilla versions are still broken.
I'm going to stop using the in-tree versions soon. That was just for testing anyway. The code will be gone from the tree soon enough.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.