Tweak the parser to eliminate two complexifying peekTokens where getToken could be used

RESOLVED FIXED in Firefox 54

Status

()

Core
JavaScript Engine
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

a year ago
Things observed while working on bug 1319416.

These conflict with bug 1336783, which is currently in feedback phase.  The conflict is relatively small (after all, these two patches are relatively small), so it probably isn't necessary to coordinate them too hard.
(Assignee)

Comment 1

a year ago
Created attachment 8834149 [details] [diff] [review]
Tweak NamedImports parsing
Attachment #8834149 - Flags: review?(arai.unmht)
(Assignee)

Comment 2

a year ago
Created attachment 8834150 [details] [diff] [review]
Tweak ExportClause parsing
Attachment #8834150 - Flags: review?(arai.unmht)
Comment on attachment 8834149 [details] [diff] [review]
Tweak NamedImports parsing

Review of attachment 8834149 [details] [diff] [review]:
-----------------------------------------------------------------

Nice simplification :D
Attachment #8834149 - Flags: review?(arai.unmht) → review+
Attachment #8834150 - Flags: review?(arai.unmht) → review+

Comment 4

a year ago
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f5e08153490
Tweak NamedImports parsing to eliminate a complexifying peekToken where getToken could be used.  r=arai
https://hg.mozilla.org/integration/mozilla-inbound/rev/616a1ffce811
Tweak ExportClause parsing to eliminate a peekToken where a simpler consuming getToken could be performed.  r=arai

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4f5e08153490
https://hg.mozilla.org/mozilla-central/rev/616a1ffce811
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.