Closed
Bug 1337143
Opened 7 years ago
Closed 7 years ago
Tweak the parser to eliminate two complexifying peekTokens where getToken could be used
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(2 files)
|
3.04 KB,
patch
|
arai
:
review+
|
Details | Diff | Splinter Review |
|
2.65 KB,
patch
|
arai
:
review+
|
Details | Diff | Splinter Review |
Things observed while working on bug 1319416. These conflict with bug 1336783, which is currently in feedback phase. The conflict is relatively small (after all, these two patches are relatively small), so it probably isn't necessary to coordinate them too hard.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8834149 -
Flags: review?(arai.unmht)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Attachment #8834150 -
Flags: review?(arai.unmht)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8834149 [details] [diff] [review] Tweak NamedImports parsing Review of attachment 8834149 [details] [diff] [review]: ----------------------------------------------------------------- Nice simplification :D
Attachment #8834149 -
Flags: review?(arai.unmht) → review+
|
|
||
Updated•7 years ago
|
Attachment #8834150 -
Flags: review?(arai.unmht) → review+
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/mozilla-inbound/rev/4f5e08153490 Tweak NamedImports parsing to eliminate a complexifying peekToken where getToken could be used. r=arai https://hg.mozilla.org/integration/mozilla-inbound/rev/616a1ffce811 Tweak ExportClause parsing to eliminate a peekToken where a simpler consuming getToken could be performed. r=arai
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4f5e08153490 https://hg.mozilla.org/mozilla-central/rev/616a1ffce811
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•