HTTP2 Huffman tables should go in a read-only data section

RESOLVED FIXED in Firefox 54

Status

()

Core
Networking: HTTP
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dmajor, Assigned: dmajor)

Tracking

(Blocks: 1 bug)

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8834234 [details] [diff] [review]
Single layer of const

Please see bug 1334254 comment 0 for background.

This patch moves about 10k from writable .data to read-only .rdata.

I originally had a version of this patch that adds constexpr to all of the Huffman structures, but lately I've been having too much trouble with constexpr and internal compiler errors. I have to resort to removing the inner 'const', even though it's a bit ugly.

(Though, HuffmanOutgoing wasn't const at either level, so that one's easy!)
Attachment #8834234 - Flags: review?(hurley)
Attachment #8834234 - Flags: review?(hurley) → review+

Comment 1

2 years ago
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1160dc58eb8
Tweak the const-ness on the HTTP2 Huffman tables. r=hurley
(Assignee)

Updated

2 years ago
Assignee: nobody → dmajor

Comment 2

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f1160dc58eb8
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.