1337250 - Error: can't open vpx_dsp/arm/idct_neon.asm.S for reading: No such file or directory

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Building on a non-Android Linux ARM fails to build with:

/tmp/ccp2RDQF.s: Assembler messages:
/tmp/ccp2RDQF.s:23: Error: can't open vpx_dsp/arm/idct_neon.asm.S for reading: No such file or directory
libvpx/vpx_dsp/arm/idct16x16_add_neon.asm.S:20: Error: non-constant expression in ".if" statement
libvpx/vpx_dsp/arm/idct16x16_add_neon.asm.S:274: Error: non-constant expression in ".if" statement
libvpx/vpx_dsp/arm/idct16x16_add_neon.asm.S:799: Error: non-constant expression in ".if" statement
libvpx/vpx_dsp/arm/idct16x16_add_neon.asm.S:844: Error: bad instruction `load_tran_low_to_s16x2 d16,d17,d18,d19,r0'
libvpx/vpx_dsp/arm/idct16x16_add_neon.asm.S:845: Error: bad instruction `load_tran_low_to_s16x2 d18,d19,d20,d21,r0'
libvpx/vpx_dsp/arm/idct16x16_add_neon.asm.S:846: Error: bad instruction `load_tran_low_to_s16x2 d20,d21,d22,d23,r0'
libvpx/vpx_dsp/arm/idct16x16_add_neon.asm.S:847: Error: bad instruction `load_tran_low_to_s16x2 d22,d23,d24,d25,r0'
libvpx/vpx_dsp/arm/idct16x16_add_neon.asm.S:848: Error: bad instruction `load_tran_low_to_s16x2 d24,d25,d26,d27,r0'
libvpx/vpx_dsp/arm/idct16x16_add_neon.asm.S:849: Error: bad instruction `load_tran_low_to_s16x2 d26,d27,d28,d29,r0'
libvpx/vpx_dsp/arm/idct16x16_add_neon.asm.S:850: Error: bad instruction `load_tran_low_to_s16x2 d28,d29,d30,d31,r0'
libvpx/vpx_dsp/arm/idct16x16_add_neon.asm.S:851: Error: bad instruction `load_tran_low_to_s16x2 d2,d3,d4,d5,r0'
libvpx/vpx_dsp/arm/idct16x16_add_neon.asm.S:952: Error: bad instruction `load_tran_low_to_s16x2 d16,d17,d18,d19,r0'
libvpx/vpx_dsp/arm/idct16x16_add_neon.asm.S:953: Error: bad instruction `load_tran_low_to_s16x2 d18,d19,d20,d21,r0'
libvpx/vpx_dsp/arm/idct16x16_add_neon.asm.S:954: Error: bad instruction `load_tran_low_to_s16x2 d20,d21,d22,d23,r0'
libvpx/vpx_dsp.o        6x16_add_neon.asm.S:955: Error: bad instruction `load_tran_low_to_s16x2 d22,d23,d24,d25,r0'
libvpx/vpx_dsp/arm/idct16x16_add_neon.asm.S:956: Error: bad instruction `load_tran_low_to_s16x2 d24,d25,d26,d27,r0'
libvpx/vpx_dsp/arm/idct16x16_add_neon.asm.S:957: Error: bad instruction `load_tran_low_to_s16x2 d26,d27,d28,d29,r0'
libvpx/vpx_dsp/arm/idct16x16_add_neon.asm.S:958: Error: bad instruction `load_tran_low_to_s16x2 d28,d29,d30,d31,r0'
libvpx/vpx_dsp/arm/idct16x16_add_neon.asm.S:959: Error: bad instruction `load_tran_low_to_s16x2 d0,d1,d2,d3,r0'

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1337250 - Fix libvpx build on non-Android ARM.

Review commit: https://reviewboard.mozilla.org/r/110264/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110264/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8834261 [details]
Bug 1337250 - Fix libvpx build on non-Android ARM.

https://reviewboard.mozilla.org/r/110264/#review111520

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8834261 [details]
Bug 1337250 - Fix libvpx build on non-Android ARM.

https://reviewboard.mozilla.org/r/110264/#review111768

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b96621c6151
Fix libvpx build on non-Android ARM. r=froydnj

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8834261 [details]
Bug 1337250 - Fix libvpx build on non-Android ARM.

Approval Request Comment
[Feature/Bug causing the regression]: Regression from bug 1331498
[User impact if declined]: Linux distros can't build Firefox for ARM
[Is this code covered by automated tests?]: N/A
[Has the fix been verified in Nightly?]: N/A
[Needs manual test from QE? If yes, steps to reproduce]: N/A
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It moves build system configuration from an "Android-only" branch to a "ARM" branch.
[String changes made/needed]: N/A

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6b96621c6151

Comment 7

[Gerry Chang [:gchang]]

Modified from Uplift Dashboard.

Comment 8

[Gerry Chang [:gchang]]

Comment on attachment 8834261 [details]
Bug 1337250 - Fix libvpx build on non-Android ARM.

Fix a build issue on non-Android ARM. Aurora53+.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bc736e4fab07