Closed Bug 1337325 Opened 3 years ago Closed 3 years ago

[geckoview] Remove moar JavaPanZoomController (JPZ) leftovers from mobile/android

Categories

(GeckoView :: General, defect)

52 Branch
All
Android
defect
Not set

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: JanH, Assigned: JanH)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1312743 +++

(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #0)
> +++ This bug was initially created as a clone of Bug #1311030 +++
> 
> It's like this never ends!

Indeed, I think there's some more code that can be removed, namely everything related to Tab.prototype.saveSessionZoom() and restoredSessionZoom(), which nobody seems to call anymore. This also means we can remove _getGeckoZoom(), _restoreZoom and _updateZoomFromHistoryEvent().

While this means that the history listener will become temporarily unused, I *don't* want to remove it yet, since I think it might be useful for fixing at least the session store part of bug 1337264.
Comment on attachment 8836473 [details]
Bug 1337325 - Remove unused zoom and scroll code from browser.js

https://reviewboard.mozilla.org/r/111896/#review113160

Yay code deletion!
Attachment #8836473 - Flags: review?(bugmail) → review+
Since this is touching the tab object history listener as well...
Depends on: 1337940
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/28c5827d707c
Remove unused zoom and scroll code from browser.js r=kats
https://hg.mozilla.org/mozilla-central/rev/28c5827d707c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Backout by ihsiao@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/1ee728de804e
Backed out changeset 28c5827d707c for tc-M(31) perma failure
Given that the test "failure" is the test timing out, I don't think this one is to blame, although since the history change listener in browser.js is also touched by bug 1337940 and this is nothing urgent, it can stay backed out until bug 1337940 sticks.
Flags: needinfo?(jh+bugzilla)
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/3f7919d07156
Remove unused zoom and scroll code from browser.js r=kats
https://hg.mozilla.org/mozilla-central/rev/3f7919d07156
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 54 → mozilla54
You need to log in before you can comment on or make changes to this bug.