Closed Bug 1337325 Opened 4 years ago Closed 4 years ago
[geckoview] Remove moar Java
Pan Zoom Controller (JPZ) leftovers from mobile/android
59 bytes, text/x-review-board-request
+++ This bug was initially created as a clone of Bug #1312743 +++ (In reply to Kartikaya Gupta (email:firstname.lastname@example.org) from comment #0) > +++ This bug was initially created as a clone of Bug #1311030 +++ > > It's like this never ends! Indeed, I think there's some more code that can be removed, namely everything related to Tab.prototype.saveSessionZoom() and restoredSessionZoom(), which nobody seems to call anymore. This also means we can remove _getGeckoZoom(), _restoreZoom and _updateZoomFromHistoryEvent(). While this means that the history listener will become temporarily unused, I *don't* want to remove it yet, since I think it might be useful for fixing at least the session store part of bug 1337264.
Comment on attachment 8836473 [details] Bug 1337325 - Remove unused zoom and scroll code from browser.js https://reviewboard.mozilla.org/r/111896/#review113160 Yay code deletion!
Attachment #8836473 - Flags: review?(bugmail) → review+
Since this is touching the tab object history listener as well...
Depends on: 1337940
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/28c5827d707c Remove unused zoom and scroll code from browser.js r=kats
backed this out for tc-M(31) perma failure, like https://treeherder.mozilla.org /logviewer.html#?job_id=79217617&repo=autoland&lineNumber=1937 https://hg.mozilla.org/mozilla-central/rev/c53368e7d1a3 https://hg.mozilla.org/mozilla-central/rev/9a9db410f207 https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=&fromchange=a437b95a0de44c025192f5d2a98c13bc0feb6a90&filter-searchStr=Android%204.3%20API15%2B%20debug%20Mochitests%20executed%20by%20TaskCluster%20test-android-4.3-arm7-api-15%2Fdebug-mochitest-31%20tc-M(31)&tochange=69dc3f79527d7cef2d3036756ca43bbf1a2f31ff Sorry we are not sure which patch causes this failure, so I backed your patches out. Please help to check it, thanks.
Backout by firstname.lastname@example.org: https://hg.mozilla.org/mozilla-central/rev/1ee728de804e Backed out changeset 28c5827d707c for tc-M(31) perma failure
Given that the test "failure" is the test timing out, I don't think this one is to blame, although since the history change listener in browser.js is also touched by bug 1337940 and this is nothing urgent, it can stay backed out until bug 1337940 sticks.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/3f7919d07156 Remove unused zoom and scroll code from browser.js r=kats
You need to log in before you can comment on or make changes to this bug.