Closed
Bug 1337387
Opened 6 years ago
Closed 6 years ago
Fix unified build bustage from merging m-c to graphics
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla54
People
(Reporter: rhunt, Assigned: rhunt)
Details
Attachments
(1 file)
5.22 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
https://treeherder.mozilla.org/#/jobs?repo=graphics&revision=f35a21d38a231b2788435268d2b7f94fd4057222 I'm guessing this is a unified build issue.
Pushed by rhunt@eqrion.net: https://hg.mozilla.org/projects/graphics/rev/34521aa2e278 Fix unified build bustage r=kats?
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 2•6 years ago
|
||
Attachment #8834446 -
Flags: review?(bugmail)
Comment 3•6 years ago
|
||
Comment on attachment 8834446 [details] [diff] [review] unified.patch Review of attachment 8834446 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/wr/WebRenderLayerManager.cpp @@ +5,5 @@ > > #include "WebRenderLayerManager.h" > > #include "apz/src/AsyncPanZoomController.h" > +#include "WebRenderLayersLogging.h" This is fine for now, but I suspect it will break again in the future. All it takes is any one file higher up in the unification hunk to include LayersLogging.h. If that happens we should probably fix this properly by moving the things in WebRenderLayersLogging.h into LayersLogging.h.
Attachment #8834446 -
Flags: review?(bugmail) → review+
Updated•5 years ago
|
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•