All users were logged out of Bugzilla on October 13th, 2018

Fix unified build bustage from merging m-c to graphics

RESOLVED FIXED in mozilla54

Status

()

Product:
Core
Component:
Graphics: WebRender
Status:
RESOLVED FIXED
Reported:
2 years ago
Modified:
2 years ago

People

(Reporter: rhunt, Assigned: rhunt)

Tracking

Version:
unspecified
Target:
mozilla54
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

unified.patch
5.22 KB, patch
kats
: review+
Details | Diff | Splinter Review

Comment 1

•
2 years ago 
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/projects/graphics/rev/34521aa2e278
Fix unified build bustage r=kats?
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Comment 2

•
2 years ago 
Created attachment 8834446 [details] [diff] [review]
unified.patch
Attachment #8834446 - Flags: review?(bugmail)

Comment 3

•
2 years ago 
Comment on attachment 8834446 [details] [diff] [review]
unified.patch

Review of attachment 8834446 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/wr/WebRenderLayerManager.cpp
@@ +5,5 @@
>  
>  #include "WebRenderLayerManager.h"
>  
>  #include "apz/src/AsyncPanZoomController.h"
> +#include "WebRenderLayersLogging.h"

This is fine for now, but I suspect it will break again in the future. All it takes is any one file higher up in the unification hunk to include LayersLogging.h. If that happens we should probably fix this properly by moving the things in WebRenderLayersLogging.h into LayersLogging.h.
Attachment #8834446 - Flags: review?(bugmail) → review+
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.