Closed Bug 1337441 Opened 7 years ago Closed 7 years ago

[webvr] Crash in mozilla::dom::VRDisplayEventBinding::get_display

Categories

(Core :: Widget: Win32, defect, P3)

Unspecified
Windows 10
defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox52 --- unaffected
firefox53 --- unaffected
firefox54 --- fixed

People

(Reporter: marcia, Assigned: kip)

References

Details

(Keywords: crash, Whiteboard: [gfx-noted][tpi:+])

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-ceaf05d4-9efa-43e0-854d-25b012170203.
=============================================================

Seen while looking at Nightly crashes - crashes started using 20170203030204 build.

Possible regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f985243bb630b2c78cd57731c8d8ab191aa09527&tochange=2aede0a97bc685e163196cc451b947a04ae6a598

Bug 1293333 is in the range. ni on :kip
Flags: needinfo?(kgilbert)
Component: Graphics → Widget: Win32
Priority: -- → P3
Whiteboard: [gfx-noted]
This call stack can only be reached when WebVR is active.  I'll take this one and investigate.
Flags: needinfo?(kgilbert)
Assignee: nobody → kgilbert
Summary: Crash in mozilla::dom::VRDisplayEventBinding::get_display → [webvr] Crash in mozilla::dom::VRDisplayEventBinding::get_display
Whiteboard: [gfx-noted] → [gfx-noted][tpi:+]
I have managed to produce the same crash while testing my patch for https://bugzilla.mozilla.org/show_bug.cgi?id=1335606

A fix should be ready shortly.
Steps to reproduce:

- Open a webvr site such as https://webvr.info/samples/03-vr-presentation.html
- Enter into the debug console:
  window.addEventListener("vrdisplayactivate", function(e) { alert(e.display.displayName) }, false);
- Then trigger the proximity sensor in an attached VR Headset.
Blocks: 1335606
I've pushed to try as a sanity check and will do some more testing tomorrow on different VR hardware to verify the fix.
Attachment #8835807 - Flags: review?(ehsan)
With the repro steps in Comment 3, I have been able to reproduce the stack in the crash report and confirm the attached patch corrects it.
Comment on attachment 8835807 [details]
Bug 1337441 - Prevent crash when accessing VRDisplayEvent.display within onvrdisplayactivate

https://reviewboard.mozilla.org/r/111398/#review112956
Attachment #8835807 - Flags: review?(ehsan) → review+
Pushed by kgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6258f4bfbf3d
Prevent crash when accessing VRDisplayEvent.display within onvrdisplayactivate r=Ehsan
https://hg.mozilla.org/mozilla-central/rev/6258f4bfbf3d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: