Closed Bug 1337459 Opened 3 years ago Closed 3 years ago
Tab URL is no longer displayed in URL bar during session restore before Gecko has loaded
STR: 1. Have at least on tab with some content open. 2. Kill Firefox and start it again. Expected: The URL of the restored foreground tab is displayed as soon as the UI has started up. Actual: The awesomebar is displaying its default "about:home" text ("Search or enter adress") and is only updated once Gecko has started and is reloading the page. Regressing push is this one: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e8d6755b7a392f5cc2b3aa58df5b185ef620747f&filter-searchStr=android%2015%20opt
Assignee: nobody → nchen
Status: NEW → ASSIGNED
We don't update ToolbarDisplayLayout when it's not ready (i.e. when it's not attached to a window yet), but when it does become ready, we should update it to the selected tab, if any.
Attachment #8837903 - Flags: review?(s.kaspari)
Attachment #8837903 - Flags: review?(s.kaspari) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c94cfb623248 Update to selected tab when ToolbarDisplayLayout is ready; r=sebastian
Comment on attachment 8837903 [details] [diff] [review] Update to selected tab when ToolbarDisplayLayout is ready (v1) Approval Request Comment [Feature/Bug causing the regression]: Bug 1329268 [User impact if declined]: Not as good user experience; URL not shown when restoring tabs [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: Not very [Why is the change risky/not risky?]: Patch is small and only affects certain scenarios when starting up [String changes made/needed]: None
Attachment #8837903 - Flags: approval-mozilla-aurora?
Comment on attachment 8837903 [details] [diff] [review] Update to selected tab when ToolbarDisplayLayout is ready (v1) Sounds best to keep things consistent for users - let's uplift to aurora.
Attachment #8837903 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified that the issue was fixed on Aurora 54 (3/16/2017) and Beta 53.0b2. Devices: -Lenovo Yoga Tablet 2 (Android 4.4.2) -Huawei Honor 5X (Android 5.1.1)
You need to log in before you can comment on or make changes to this bug.