Closed
Bug 1337469
Opened 7 years ago
Closed 7 years ago
browser/locales/searchplugins/odpiralni.xml shouldn't provide an updateURL
Categories
(Firefox :: Search, defect)
Tracking
()
RESOLVED
FIXED
Firefox 54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: florian, Assigned: mkaply)
Details
Attachments
(1 file)
4.34 KB,
patch
|
flod
:
review+
|
Details | Diff | Splinter Review |
I don't think the built-in search plugins are meant to update independently of the browser. A quick search for updateurl shows that currently we have only one engine in the tree providing an UpdateURL, so I think it's a mistake: http://searchfox.org/mozilla-central/rev/848c29538ab007fb95dc6cff194f0e3d3809613d/browser/locales/searchplugins/odpiralni.xml#10 (it's only used for the sl locale)
Comment 1•7 years ago
|
||
(In reply to Florian Quèze [:florian] [:flo] from comment #0) > I don't think the built-in search plugins are meant to update independently > of the browser. Definitely. My guess is that the XML was taken directly from the website, and nobody noticed the updateurl was there (the file predates me).
Comment 2•7 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #1) > (the file predates me). For reference, it was added in bug 542528
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8839605 -
Flags: review?(francesco.lodolo)
Updated•7 years ago
|
Attachment #8839605 -
Flags: review?(francesco.lodolo) → review+
Updated•7 years ago
|
Assignee: nobody → mozilla
Assignee | ||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a79f71b7d7a3e3d0189b9bcd801ee76548ddcc70 Bug 1337469 - Remove UpdateUrl for odpiralni.xml. r=flod
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a79f71b7d7a3
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in
before you can comment on or make changes to this bug.
Description
•