Closed
Bug 1337496
Opened 7 years ago
Closed 5 years ago
Don't animate the pinboard count unless the count actually changed
Categories
(Tree Management :: Treeherder: Frontend, defect)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: KWierso, Unassigned)
Details
I'd argue that the pulse animation should only happen if the count of pinned jobs in the pinboard actually changes. Thoughts?
Comment 1•7 years ago
|
||
For historical reference my pulsing at all times was intentional, to cue the user when they are trying to pin a job that is already pinned. Versus hitting spacebar on a selected job and thinking "nothing happened" - since there is no UI feedback of any kind in that use case. But whatever you guys want :) I suppose you could replace the counter pulse on a zero-pin-count change with a blue info notification banner indicating the job is already pinned. But I thought a simple pulse of the counter was less annoying.
Updated•7 years ago
|
Component: Treeherder → Treeherder: Frontend
Comment 2•5 years ago
|
||
I agree with jfrench on this one. Let's keep it as-is. I think this is a nice way to draw the user's attention to what's happening.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•