Don't animate the pinboard count unless the count actually changed

NEW
Unassigned

Status

2 years ago
a year ago

People

(Reporter: KWierso, Unassigned)

Tracking

Details

(Reporter)

Description

2 years ago
I'd argue that the pulse animation should only happen if the count of pinned jobs in the pinboard actually changes.

Thoughts?
For historical reference my pulsing at all times was intentional, to cue the user when they are trying to pin a job that is already pinned. Versus hitting spacebar on a selected job and thinking "nothing happened" - since there is no UI feedback of any kind in that use case. But whatever you guys want :)

I suppose you could replace the counter pulse on a zero-pin-count change with a blue info notification banner indicating the job is already pinned. But I thought a simple pulse of the counter was less annoying.

Updated

a year ago
Component: Treeherder → Treeherder: Frontend
You need to log in before you can comment on or make changes to this bug.