1337516 - Debugging xpcshell tests is broken

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Alexandre Poirot [:ochameau]]

When connecting from the connect page (yes, we still have to use that...), we get the following error from the connect page:
Object { from: "root", error: "noAddons", message: "This root actor has no browser  addons." }

That's becauses this call throws and prevent going further.
http://searchfox.org/mozilla-central/source/devtools/client/framework/connect/connect.js#82
  let response = yield gClient.listAddons();

I imagine that's a snicky regression from bug 1227978.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1337516 - Fix the connect page when connecting to xpcshell tests.

Review commit: https://reviewboard.mozilla.org/r/110464/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110464/

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8834611 [details]
Bug 1337516 - Fix the connect page when connecting to xpcshell tests.

https://reviewboard.mozilla.org/r/110464/#review111728

Thanks for the fix!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3003e634d6d2
Fix the connect page when connecting to xpcshell tests. r=jryans

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3003e634d6d2