1337536 - Trivially true assertion in MessageType::__init__

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Andrew McCreight [:mccr8]]

MessageType::__init__ contains this assertion:
  assert not (ctor or dtor) or type is not None

"type" is supposed to be "cdtype". This assertion happens to not fail because "type" happens to be some kind of existing object, so the second part of the "or" always evaluates to true. (This bug appears to date to the initial landing of IPDL.)

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1337536 - MessageType ctor assert should check cdtype.

type is some existing Python object, so this assertion can never fail.

Looking at GatherDecls::visitMessageDecl, I think this is supposed to
be checking cdecl.

Review commit: https://reviewboard.mozilla.org/r/110836/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110836/

Comment 2

[Andrew McCreight [:mccr8]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=24d9f2d0eba22a0d479e1454c5299f8081af9cff

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8835146 [details]
Bug 1337536 - MessageType ctor assert should check cdtype.

https://reviewboard.mozilla.org/r/110836/#review112654

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59c0ce731318
MessageType ctor assert should check cdtype. r=billm

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/59c0ce731318