Closed Bug 1337536 Opened 5 years ago Closed 5 years ago

Trivially true assertion in MessageType::__init__

Categories

(Core :: IPC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file)

MessageType::__init__ contains this assertion:
  assert not (ctor or dtor) or type is not None

"type" is supposed to be "cdtype". This assertion happens to not fail because "type" happens to be some kind of existing object, so the second part of the "or" always evaluates to true. (This bug appears to date to the initial landing of IPDL.)
Comment on attachment 8835146 [details]
Bug 1337536 - MessageType ctor assert should check cdtype.

https://reviewboard.mozilla.org/r/110836/#review112654
Attachment #8835146 - Flags: review?(wmccloskey) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/59c0ce731318
MessageType ctor assert should check cdtype. r=billm
https://hg.mozilla.org/mozilla-central/rev/59c0ce731318
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.